[SPARK-52719][SQL] Support using scalar UDFs in TVF arguments#55950
Open
yadavay-amzn wants to merge 1 commit into
Open
[SPARK-52719][SQL] Support using scalar UDFs in TVF arguments#55950yadavay-amzn wants to merge 1 commit into
yadavay-amzn wants to merge 1 commit into
Conversation
Narrows the check that rejects SQL functions in TVF arguments to only reject table-valued functions, allowing scalar UDFs to be used as TVF arguments. Closes #SPARK-52719
Contributor
Author
|
@allisonwang-db Could you please take a look at this one-liner when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Narrows the check in
ResolveSQLFunctionsthat rejects SQL functions in TVF arguments to only reject table-valued functions, allowing scalar UDFs to pass through for normal resolution.Why are the changes needed?
SELECT * FROM tvf(scalar_udf(true))incorrectly throwsAnalysisException: Using SQL function ... in SQLTableFunction is not supported. Scalar UDFs return scalar values and should be valid TVF arguments.Does this PR introduce any user-facing change?
Yes, scalar SQL UDFs can now be used as arguments to table-valued functions.
How was this patch tested?
Added test in
SQLFunctionSuitethat creates a scalar UDF and a TVF, then verifiesSELECT * FROM table_func(scalar_udf(1))returns the expected result. Test fails without the fix (AnalysisException), passes with it.Was this patch authored or co-authored using generative AI tooling?
No