fix issue MapType as a type hint for schema 55900#55931
Open
deepanshu36 wants to merge 2 commits into
Open
Conversation
Author
|
please have a look at the changes |
deepanshu36
commented
May 17, 2026
Author
deepanshu36
left a comment
There was a problem hiding this comment.
Problem
from_json accepts MapType as a valid schema at runtime and
is even shown in the official documentation. However, the type
stub does not include MapType in the Union, causing type
checkers to raise an error.
Fixes #55900
Changes
- Added
MapTypeto theschemaparameter type hint infrom_json - Added
MapTypeto the imports in the type stub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
I have added a one line change to let spark know that u can have MapType also as a schema argument, earlier it did not consider schema argument in the file and niether imported it, i have added those change in the latest commit. please have a look