HIVE-29572: ACID Compaction: Cleaner should mark a compaction failed when its txn is aborted#6498
Open
kuczoram wants to merge 1 commit into
Open
HIVE-29572: ACID Compaction: Cleaner should mark a compaction failed when its txn is aborted#6498kuczoram wants to merge 1 commit into
kuczoram wants to merge 1 commit into
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
kuczoram
changed the title
…when its txn is aborted
kuczoram
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?###
When a compaction is fetched by the cleaner, first check the state of the compaction's transaction. If it is already aborted, delete nothing, but mark the compaction as failed.
Why are the changes needed?###
It can happen that a compaction is marked as finished and get into "ready for cleaning" state, but the compaction txn stays open. And when the timeout reached, the txn gets aborted.
With min.history.level, a compaction like this can block the cleaning for all consecutive compaction, even after the txn is aborted.
Does this PR introduce any user-facing change?###
No
How was this patch tested?###
The scenarios are covered in TestCleaner unit test.