Skip to content

HIVE-29598: Fix vectorized outer join wrong results due to stale scratch column values #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soumyakanti3578 merged 10 commits into from
May 21, 2026
Merged

HIVE-29598: Fix vectorized outer join wrong results due to stale scratch column values #6486

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b067c9e
HIVE-29598: Fix vectorized outer join wrong results due to stale scra…
ryukobayashi May 15, 2026
6b31424
HIVE-29598: Add regression test for vectorized outer join stale scrat…
ryukobayashi May 18, 2026
18801de
HIVE-29598: Add unit tests and handle DecimalColumnVector in clearVec…
ryukobayashi May 18, 2026
937c6d3
HIVE-29598: addressing PR feedback + using correct test case + unit t…
konstantinb May 18, 2026
eaf57ef
Merge pull request #1 from konstantinb/HIVE-29598-followup
ryukobayashi May 19, 2026
4009d83
HIVE-29598: SQ feedback + comments' cleanup
konstantinb May 19, 2026
fe43669
Merge pull request #2 from konstantinb/HIVE-29598-sq-clnp
ryukobayashi May 20, 2026
0d8b142
Update ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/Test…
ryukobayashi May 21, 2026
b8e8a04
Update ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/Test…
ryukobayashi May 21, 2026
75dc03d
HIVE-29598: address review feedback — add Decimal64ColumnVector to pa…
ryukobayashi May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...g/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
import org.apache.hadoop.hive.ql.exec.persistence.MapJoinTableContainer;
import org.apache.hadoop.hive.ql.exec.vector.BytesColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.ColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.DoubleColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.IntervalDayTimeColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.LongColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.TimestampColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.VectorizationContext;
import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
import org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression;
Expand Down Expand Up @@ -590,13 +593,15 @@ protected void generateOuterNulls(VectorizedRowBatch batch, int[] noMatchs,
ColumnVector colVector = batch.cols[column];
colVector.noNulls = false;
colVector.isNull[batchIndex] = true;
clearVectorValue(colVector, batchIndex);
}

// Small table values are set to null.
for (int column : smallTableValueColumnMap) {
ColumnVector colVector = batch.cols[column];
colVector.noNulls = false;
colVector.isNull[batchIndex] = true;
clearVectorValue(colVector, batchIndex);
}
}
}
Expand Down Expand Up @@ -749,13 +754,32 @@ protected void generateOuterNullsRepeatedAll(VectorizedRowBatch batch) throws Hi
colVector.noNulls = false;
colVector.isNull[0] = true;
colVector.isRepeating = true;
clearVectorValue(colVector, 0);
}

for (int column : smallTableValueColumnMap) {
ColumnVector colVector = batch.cols[column];
colVector.noNulls = false;
colVector.isNull[0] = true;
colVector.isRepeating = true;
clearVectorValue(colVector, 0);
}
}

private static void clearVectorValue(ColumnVector colVector, int index) {
if (colVector instanceof LongColumnVector) {
((LongColumnVector) colVector).vector[index] = 0L;
} else if (colVector instanceof DoubleColumnVector) {
((DoubleColumnVector) colVector).vector[index] = 0.0;
} else if (colVector instanceof BytesColumnVector) {
BytesColumnVector bcv = (BytesColumnVector) colVector;
bcv.vector[index] = null;
bcv.start[index] = 0;
bcv.length[index] = 0;
} else if (colVector instanceof TimestampColumnVector) {
((TimestampColumnVector) colVector).setNullValue(index);
} else if (colVector instanceof IntervalDayTimeColumnVector) {
((IntervalDayTimeColumnVector) colVector).setNullValue(index);
Comment thread
ryukobayashi marked this conversation as resolved.
Outdated
}
}

Expand Down
Loading