HIVE-29514: Optimize UDF Unhex and improve its test coverage#6471
Open
tanishq-chugh wants to merge 3 commits into
Open
HIVE-29514: Optimize UDF Unhex and improve its test coverage#6471tanishq-chugh wants to merge 3 commits into
tanishq-chugh wants to merge 3 commits into
Conversation
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests passed
tests pending
tests unstable
and removed
tests pending
tests passed
tests unstable
labels
|
Comment on lines
+68
to
+70
| if (val == -1) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
Please add a test for invalid character in an odd-length input.
Example: G.
Comment on lines
+74
to
83
| while (i < len) { | ||
| int high = decodeHexChar(textBytes[i++]); | ||
| int low = decodeHexChar(textBytes[i++]); | ||
|
|
||
| if (high == -1 || low == -1) { | ||
| return null; | ||
| } | ||
|
|
||
| result[resIdx++] = (byte) ((high << 4) | low); | ||
| } |
Contributor
There was a problem hiding this comment.
How about:
while (i < len) {
int high, low;
if ((high = decodeHexChar(textBytes[i++])) == -1 ||
(low = decodeHexChar(textBytes[i++])) == -1) {
return null;
}
result[resIdx++] = (byte) ((high << 4) | low);
}
so that we don't compute low if high == -1. Consider adding tests for when high == -1 and low == -1.
| Text hexEmpty = new Text(""); | ||
| byte[] expectedEmpty = new byte[0]; | ||
| assertArrayEquals(expectedEmpty, udf.evaluate(hexEmpty)); | ||
| } |
Contributor
There was a problem hiding this comment.
It would be nice to have tests for
- mixed case:
aABb9 - boundary values
- lower case, as all tests are for upper case right now
Also, maybe not in this file, but are there any tests for hex(unhex(...)) and unhex(hex(..))?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the UDF Unhex and its test coverage
Why are the changes needed?
Better performance
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual testing + java test