Skip to content

Fix PipelineOptions deserialization NPE#38531

Merged
shunping merged 3 commits into
apache:masterfrom
shunping:fix-python-flink-pvr
May 19, 2026
Merged

Fix PipelineOptions deserialization NPE#38531
shunping merged 3 commits into
apache:masterfrom
shunping:fix-python-flink-pvr

Conversation

@shunping
Copy link
Copy Markdown
Collaborator

@shunping shunping commented May 18, 2026

@github-actions github-actions Bot added the java label May 18, 2026
@shunping shunping changed the title Fix Pythn Flink PVR Fix Python Flink PVR May 18, 2026
@Abacn Abacn mentioned this pull request May 18, 2026
3 tasks
@shunping shunping marked this pull request as ready for review May 18, 2026 21:32
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a regression in Python Flink PVR tests caused by an upgrade to Jackson 2.14+. By moving away from a static, shared deserialization context and instead creating fresh, parser-associated contexts during deserialization, the changes resolve NullPointerExceptions that occurred when deserializers attempted to access transient parser fields.

Highlights

  • Jackson Deserialization Fix: Replaced the static DESERIALIZATION_CONTEXT with a dynamic creation approach to prevent NullPointerExceptions in Jackson 2.14+.
  • Context Initialization: Updated deserialization logic to properly associate contexts with active parsers instead of using copy(), which was causing issues with transient parser fields.
  • Test Trigger: Added a trivial change to the trigger file to ensure the Python Flink PVR test suite runs.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shunping
Copy link
Copy Markdown
Collaborator Author

@shunping
Copy link
Copy Markdown
Collaborator Author

r: @Abacn @aIbrahiim @stankiewicz

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses potential NullPointerExceptions in Jackson 2.14+ by ensuring that DefaultDeserializationContext is properly initialized with a parser instead of using the copy() method, which leaves the transient parser field null. The changes are applied in PipelineOptionsFactory.java within the computeDeserializerForMethod and deserializeNode methods. Feedback from the review suggests centralizing the context creation logic into a private helper method to reduce code duplication and improve maintainability.

@shunping shunping changed the title Fix Python Flink PVR Fix PipelineOptions deserialization NPE May 19, 2026
@stankiewicz stankiewicz self-requested a review May 19, 2026 10:51
@shunping shunping merged commit 79ae776 into apache:master May 19, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Python PVR Flink job is flaky

3 participants