Skip to content

cap v2 streaming ValidatesRunner forks #38483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aIbrahiim wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

cap v2 streaming ValidatesRunner forks #38483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_V2_Streaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run!",
"modification": 1,
"modification": 2
}
4 changes: 2 additions & 2 deletions .github/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow_V2_Streaming.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
beam_PostCommit_Java_ValidatesRunner_Dataflow_V2_Streaming:
name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
runs-on: [self-hosted, ubuntu-24.04, main]
timeout-minutes: 510
timeout-minutes: 720
strategy:
matrix:
job_name: [beam_PostCommit_Java_ValidatesRunner_Dataflow_V2_Streaming]
Expand Down Expand Up @@ -101,4 +101,4 @@ jobs:
commit: '${{ env.prsha || env.GITHUB_SHA }}'
comment_mode: ${{ github.event_name == 'issue_comment' && 'always' || 'off' }}
files: '**/build/test-results/**/*.xml'
large_files: true
large_files: true
4 changes: 3 additions & 1 deletion runners/google-cloud-dataflow-java/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,14 +258,15 @@ def createRunnerV2ValidatesRunnerTest = { Map args ->
def pipelineOptions = args.pipelineOptions ?: runnerV2PipelineOptions
def excludedTests = args.excludedTests ?: []
def excludedCategories = args.excludedCategories ?: []
def maxParallelForksForTest = args.maxParallelForks != null ? args.maxParallelForks : Integer.MAX_VALUE

return tasks.create(name: name, type: Test, group: "Verification") {
dependsOn buildAndPushDockerJavaContainer
systemProperty "beamTestPipelineOptions", JsonOutput.toJson(pipelineOptions)

// Increase test parallelism up to the number of Gradle workers. By default this is equal
// to the number of CPU cores, but can be increased by setting --max-workers=N.
maxParallelForks Integer.MAX_VALUE
maxParallelForks maxParallelForksForTest
classpath = configurations.validatesRunner
testClassesDirs = files(project(":sdks:java:core").sourceSets.test.output.classesDirs) +
files(project(project.path).sourceSets.test.output.classesDirs)
Expand Down Expand Up @@ -613,6 +614,7 @@ task validatesRunnerV2Streaming {
description = "Runs the ValidatesRunner tests on Dataflow Runner V2 forcing streaming mode"
dependsOn(createRunnerV2ValidatesRunnerTest(
name: 'validatesRunnerV2TestStreaming',
maxParallelForks: 4,
pipelineOptions: runnerV2PipelineOptions + ['--streaming', '--experiments=enable_streaming_engine'],
excludedCategories: [
'org.apache.beam.sdk.testing.LargeKeys$Above10KB',
Expand Down
Loading