Add explicit read-only permissions to CI workflows#38468
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Assigning reviewers: R: @Abacn for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
4a5bf1b to
7e16bb6
Compare
|
Hi @Amar3tto, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
|
I don't think this actually enhances our security and it has the potential to break things, so I'm -1 on taking it. I think the default settings are fine for most use workflows |
Summary
permissionsblocks withcontents: readto 15 workflows that currently rely on default token scopes.Why
These workflows only need repository read access for checkout and CI execution. Explicit permissions harden GitHub Actions token usage and document intent.
Notes
.github/workflows/build_release_candidate.yml.github/workflows/git_tag_released_version.yml.github/workflows/beam_Playground_Precommit.ymlbecause it usespull_request_target+ custom setup logic that should be reviewed separately for least-privilege writes.