Skip to content

base-action: persist execution log when SDK throws (e.g. max-turns) #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
STRd6 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

base-action: persist execution log when SDK throws (e.g. max-turns) #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions base-action/src/run-claude-sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ export async function runClaudeWithSdk(

const messages: SDKMessage[] = [];
let resultMessage: SDKResultMessage | undefined;
let sdkError: unknown;

try {
for await (const message of query({ prompt, options: sdkOptions })) {
Expand All @@ -172,18 +173,24 @@ export async function runClaudeWithSdk(
}
} catch (error) {
console.error("SDK execution error:", error);
throw new Error(`SDK execution error: ${error}`);
sdkError = error;
}

const result: ClaudeRunResult = {
conclusion: "failure",
};

// Write execution file
// Persist the execution file regardless of whether the SDK threw, so
// failures like max-turns still leave a partial transcript on disk for
// downstream upload/inspection steps.
try {
await writeFile(EXECUTION_FILE, JSON.stringify(messages, null, 2));
console.log(`Log saved to ${EXECUTION_FILE}`);
result.executionFile = EXECUTION_FILE;
// Publish the output eagerly: index.ts re-throws on SDK errors before
// reaching its own setOutput calls, so steps gated on `execution_file`
// would otherwise never see it on the failure path.
core.setOutput("execution_file", EXECUTION_FILE);
} catch (error) {
core.warning(`Failed to write execution file: ${error}`);
}
Expand All @@ -195,6 +202,11 @@ export async function runClaudeWithSdk(
if (initMessage && "session_id" in initMessage && initMessage.session_id) {
result.sessionId = initMessage.session_id as string;
core.info(`Set session_id: ${result.sessionId}`);
core.setOutput("session_id", result.sessionId);
}

if (sdkError) {
throw new Error(`SDK execution error: ${sdkError}`);
}

if (!resultMessage) {
Expand Down