fix(session): normalize session directory filters across path variants#28040
fix(session): normalize session directory filters across path variants#28040jacky-2014-sn wants to merge 2 commits into
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate PRs FoundPR #28027 - "fix(session): match Windows directory separators"
PR #26580 - "fix: normalize Windows desktop session paths"
PR #26463 - "fix: normalize Windows session directory filters"
These PRs (#28027 in particular) appear to be addressing the same or closely related issues with Windows path separators in session handling. Recommend checking if #28027 is an earlier attempt at the same fix or if they address different aspects of the issue. |
|
I took a closer look at the PRs the duplicate bot flagged. There is definitely overlap with #28027 and #26463 in the shared session directory-matching logic, and #26580 is also related from the desktop/session path normalization side. My understanding of the difference in scope is:
So I agree this is part of the same bug cluster, but my intent with this PR was to make sure the fix is applied consistently across the shared session list path, the v2 path, and cursor validation, rather than only the shared filtering logic. If you would prefer this work to be folded into one of the earlier PRs instead, I'm happy to rework this into a narrower follow-up or close it and move the extra coverage there. |
Issue for this PR
Closes #28038
Type of change
What does this PR do?
This normalizes session directory matching so Windows slash-equivalent paths are treated as the same location.
It updates the shared session list filtering path, keeps legacy rows without
pathmatching correctly, and applies the same comparison rules to v2 session list filters and cursor validation.How did you verify your code works?
bun test --timeout 30000 test/server/session-list.test.tsbun typecheckScreenshots / recordings
N/A
Checklist