fix(tui): open variant dialog for selected model#28024
Open
mturac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27893
Type of change
What does this PR do?
When a model is selected from
/models, the follow-up variant check now reads variants for that selected provider/model instead of relying on the current model memo. This lets reasoning-effort models open the variant picker when no saved choice exists, while keeping saved choices closed.How did you verify your code works?
bun test test/cli/cmd/tui/dialog-model.test.ts --timeout 30000bun typecheckbunx prettier --check src/cli/cmd/tui/context/local.tsx src/cli/cmd/tui/component/dialog-model.tsx test/cli/cmd/tui/dialog-model.test.tsgit diff --checkbun turbo typecheckScreenshots / recordings
N/A; behavior covered by the targeted dialog selection test.
Checklist