-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Send welcome message in debugger console on connect #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rentziass
wants to merge
4
commits into
main
Choose a base branch
from
rentziass/debugger-welcome-message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+305
−13
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
45aea30
Add DebuggerWelcomeMessage to job message and config
rentziass 6f69411
Send welcome message on debugger configurationDone
rentziass ff6d568
Add tests for debugger welcome message
rentziass a57b69e
Reset welcome message flag on client reconnect
rentziass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| using GitHub.DistributedTask.Pipelines; | ||
| using GitHub.DistributedTask.Pipelines; | ||
|
|
||
| namespace GitHub.Runner.Worker.Dap | ||
| { | ||
|
|
@@ -8,10 +8,11 @@ namespace GitHub.Runner.Worker.Dap | |
| /// </summary> | ||
| public sealed class DebuggerConfig | ||
| { | ||
| public DebuggerConfig(bool enabled, DebuggerTunnelInfo tunnel) | ||
| public DebuggerConfig(bool enabled, DebuggerTunnelInfo tunnel, string welcomeMessage = null) | ||
| { | ||
| Enabled = enabled; | ||
| Tunnel = tunnel; | ||
| WelcomeMessage = welcomeMessage; | ||
| } | ||
|
|
||
| /// <summary>Whether the debugger is enabled for this job.</summary> | ||
|
|
@@ -23,6 +24,12 @@ public DebuggerConfig(bool enabled, DebuggerTunnelInfo tunnel) | |
| /// </summary> | ||
| public DebuggerTunnelInfo Tunnel { get; } | ||
|
|
||
| /// <summary> | ||
| /// Optional welcome message for the debugger console. | ||
| /// Null = show default help, empty = show nothing, non-empty = show as-is. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same question about the comment. |
||
| /// </summary> | ||
| public string WelcomeMessage { get; } | ||
|
|
||
| /// <summary>Whether the tunnel configuration is complete and valid.</summary> | ||
| public bool HasValidTunnel => Tunnel != null | ||
| && !string.IsNullOrEmpty(Tunnel.TunnelId) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -267,6 +267,18 @@ public DebuggerTunnelInfo DebuggerTunnel | |
| set; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Optional welcome message to show in the debugger console when a | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the comment about null/empty right? |
||
| /// client connects. Null means "use the default help text", empty | ||
| /// string means "show nothing", any other value is displayed as-is. | ||
| /// </summary> | ||
| [DataMember(EmitDefaultValue = false)] | ||
| public string DebuggerWelcomeMessage | ||
| { | ||
| get; | ||
| set; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets the workflow-level action dependencies (lockfile entries) | ||
| /// </summary> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.