Skip to content

fix: reduce excessive MISSING_TRANSLATION warnings for fallback locales #9294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lifeizhou-ap merged 10 commits into from
May 18, 2026
+20 −1
Merged

fix: reduce excessive MISSING_TRANSLATION warnings for fallback locales #9294

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b5b945f
silence MISSING_TRANSLATION warnings for fallback locales
lifeizhou-ap May 18, 2026
eb2c2bf
fixed typecheck
lifeizhou-ap May 18, 2026
d58242c
fixed tests
lifeizhou-ap May 18, 2026
1218484
address comments
lifeizhou-ap May 18, 2026
27bc22a
Revert "address comments"
lifeizhou-ap May 18, 2026
a31ff32
Revert "fixed tests"
lifeizhou-ap May 18, 2026
f052b9a
Revert "fixed typecheck"
lifeizhou-ap May 18, 2026
e63d60f
Revert "silence MISSING_TRANSLATION warnings for fallback locales"
lifeizhou-ap May 18, 2026
1111aab
Merge branch 'main' into lifei/remove-default-lan-error
lifeizhou-ap May 18, 2026
f1032c1
suppressed excessive warning
lifeizhou-ap May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ui/desktop/src/renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@ const App = lazy(() => import('./App'));

const TELEMETRY_CONFIG_KEY = 'GOOSE_TELEMETRY_ENABLED';

let warnedFallbackLocale = false;
function handleIntlError(err: { code: string; message?: string }) {
if (err.code === 'MISSING_TRANSLATION' && currentLocale !== currentMessageLocale) {
if (!warnedFallbackLocale) {
warnedFallbackLocale = true;
console.warn(
`[i18n] Locale "${currentLocale}" has no translations; falling back to "${currentMessageLocale}".`
);
}
return;
}
console.error(err);
}

(async () => {
// Check if we're in the launcher view (doesn't need goosed connection)
const isLauncher = window.location.hash === '#/launcher';
Expand Down Expand Up @@ -50,7 +64,12 @@ const TELEMETRY_CONFIG_KEY = 'GOOSE_TELEMETRY_ENABLED';

ReactDOM.createRoot(document.getElementById('root')!).render(
<React.StrictMode>
<IntlProvider locale={currentLocale} defaultLocale="en" messages={messages}>
<IntlProvider
locale={currentLocale}
defaultLocale="en"
messages={messages}
onError={handleIntlError}
>
<Suspense fallback={SuspenseLoader()}>
<ConfigProvider>
<ErrorBoundary>
Expand Down
Loading