fix(desktop): ScheduleModal error message styling#9278
Merged
Conversation
The ScheduleModal had the error messages styled with danger border, background and text. This meant that the messages were not able to be seen due to the red-on-red. This has been addressed by removing the danger background style so that only the text is styled. Additionally, the schedule name and source fields have been marked up in a similar way to the CreateRecipe modal. Required fields have an explicit asterix `*` to give a visual indicator that they are required. Signed-off-by: SteveO <steve.officer@gmail.com>
steveofficer
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the desktop Schedule modal UI to improve error readability and align required-field labeling with other modals (e.g., the recipe creation flow).
Changes:
- Removes the “danger” background styling from Schedule modal error messages to avoid red-on-red unreadable text.
- Adds explicit required-field asterisks to the Schedule name and Source labels for clearer UX consistency.
Comment on lines
+242
to
+244
| <label className={modalLabelClassName}> | ||
| {intl.formatMessage(i18n.sourceLabel)} <span className="text-red-500">*</span> | ||
| </label> |
steveofficer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ScheduleModal had the error messages styled with danger border, background and text. This meant that the messages were not able to be seen due to the red-on-red.
This has been addressed by removing the danger background style so that only the text is styled.
Additionally, the schedule name and source fields have been marked up in a similar way to the CreateRecipe modal. Required fields have an explicit asterix
*to give a visual indicator that they are required.Testing
This has been manually tested.
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
No visual indicator
Unreadable error text
After:
Visual indicator added to labels
Error message styling fixed
