feat(tui): diff viewer#9260
Conversation
alexhancock
requested review from
DOsinga,
jamadeo,
jh-block,
lifeizhou-ap and
michaelneale
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 774f02a0e3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The DiffViewer component classifies lines by prefix (+, -, @@) and applies its own coloring. Passing --color=always wraps lines in ANSI escape codes, which breaks prefix detection and renders everything as plain context. Signed-off-by: Douwe Osinga <douwe@squareup.com>
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Looks good — nice feature! I pushed one fix: the git diff call was using --color=always, which wraps lines in ANSI escape codes and breaks the classifyLine() prefix detection in DiffViewer. Changed to --no-color since the component does its own coloring. Also removed the redundant default export.
hi from goose!
2 participants
Summary
I often find myself wanting to see the diff and then iterate with goose, so this PR:
/diff. Can see longer term about integrating with feat: slash commands (built-in, skill, recipe) in acp server #9238 as that settlesTesting
Local usage (see demo)
Related Issues
N/A
Screenshots/Demos (for UX changes)
diffs-in-tui.mov