fix(web): clean up now view shortcuts — labels, key sequences, and platform tooltip#1807
Open
HirenGajjar wants to merge 1 commit into
Open
fix(web): clean up now view shortcuts — labels, key sequences, and platform tooltip#1807HirenGajjar wants to merge 1 commit into
HirenGajjar wants to merge 1 commit into
Conversation
tyler-dane
reviewed
May 22, 2026
| navigator.platform.toUpperCase().includes("MAC") | ||
| ? "⌘+Enter" | ||
| : "Ctrl+Enter" | ||
| } |
Contributor
There was a problem hiding this comment.
Plz use the icons instead of just the text. Additionally, it should have a space between the elements so it looks more like this:
⌘ + Enter (except instead of ⌘ it's the command icon)
This will help us give the user a consistent experience.
tyler-dane
requested changes
May 22, 2026
Contributor
tyler-dane
left a comment
tyler-dane
left a comment
There was a problem hiding this comment.
Pretty close, just a few requests
- Remove Logout shortcut from day/week sidebar (accessible via cmd palette) - Rename 'Toggle sidebar' to 'Close sidebar' - Rename 'Toggle shortcuts' to 'Show shortcuts' - Change edit description shortcut from e to e d sequence - Change edit reminder shortcut from r to e r sequence - Move reminder shortcut from global to now view - Show platform-aware key (⌘ or Ctrl) on save tooltip - Remove unused isAuthenticated from getShortcuts and callers
HirenGajjar
force-pushed
the
fix/shortcut-labels-and-keys
branch
from
0e35757 to
30e8f0c
Compare
Author
|
Updated — using ShortCutLabel with k="Mod" now, renders the right icon per platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1791
etoedsequencertoersequenceisAuthenticatedparam fromgetShortcutsand its callers