Skip to content

docs(docs): record 0011 PR 2.8 (DataState adoption — digest)#1729

Merged
Skords-01 merged 1 commit into
mainfrom
devin/1777916826-0011-progress-2-8
May 4, 2026
Merged

docs(docs): record 0011 PR 2.8 (DataState adoption — digest)#1729
Skords-01 merged 1 commit into
mainfrom
devin/1777916826-0011-progress-2-8

Conversation

@Skords-01
Copy link
Copy Markdown
Owner

@Skords-01 Skords-01 commented May 4, 2026

Summary

Записує прогрес PR 2.8 (DataState consumer adoption — HubChat / coach / digest зона) у docs/initiatives/0011-foundation-adoption-and-process-discipline.md. PR 2.8 (#1726) — це останній у блоці DataState consumer-adoption Phase 2 (після 2.4/2.5/2.6/2.7 для finyk/fizruk/nutrition/routine).

Зміни:

  • Status header (рядок 4): додано 2.8 (#1726) до списку opened DataState-PR-ів. Сигнал змінено з "2.8 HubChat/coach/digest залишається" на "2.9 ESLint rule і 2.1 ManualExpenseSheet залишаються" — consumer-adoption блок Phase 2 закрито.
  • Phase 2 table row 2.8 (рядок 135): ETA "+3 дні" → "Opened 2026-05-04 — #1726". Колонка «Файли» уточнена: core/insights/WeeklyDigestCard.tsx DigestContent 4-state ladder — єдиний Skeleton-based panel-loading site у HubChat / coach / digest зоні core/**.
  • Footnote (рядок 137): розширено пояснення чому інші HubChat / coach / digest "панелі" з пропозиції (HubChatHistoryPanel, CoachInsightsPanel, DigestPanel) не мали реальних DataState-targets — AssistantAdviceCard без skeleton imports і кешує last-good insight, HubChatHistoryDrawer local-first, HubChat.tsx / HubChatBody / HubChatComposer стрімлять без panel-skeleton-у.

Governing Skill

  • Primary skill: .agents/skills/sergeant-review-and-merge/SKILL.md (governance/docs freshness)
  • Secondary skill (if truly needed): .agents/skills/sergeant-feature-delivery/SKILL.md (initiative tracking)

Playbook

  • Primary playbook: n/a — це plain initiative-doc update, не code change.
  • Why this playbook: see above.
  • If no playbook matched, why: doc-only оновлення статусу ініціативи; такі правки не потребують playbook-у.

Verification

pnpm prettier --write docs/initiatives/0011-foundation-adoption-and-process-discipline.md   # formatted
git diff --stat origin/main                                                                 # 1 file, +9/-9

Additional checks:

Docs and Governance

  • I updated docs that changed with the behavior, contract, workflow, or rollout. (це сам doc-update PR)
  • I checked whether AGENTS.md needed an update. (no — інваріанти не змінились)
  • I checked whether a playbook or skill needed an update. (no — DataState contract уже описаний у sergeant-web-ui skill)
  • I checked whether governance docs or review docs needed an update. (no — hard-rules не торкнуто)

Updated docs:

  • docs/initiatives/0011-foundation-adoption-and-process-discipline.md

Risk and Rollout

  • User-visible risk: none — pure doc update.
  • Rollout / deploy order: merge до main. Vercel deploy на docs-only PR не потрібен (не зачіпає apps).
  • Backout plan: revert single commit на main; статус-рядок повернеться до прев формулювання.

Hard Rule #15

  • I read AGENTS.md before coding.
  • Internal docs I touched are in Ukrainian.
  • I did not use --no-verify.

Reviewer Notes

  • Цей PR супроводжує PR 2.8 (refactor(web): adopt <DataState> in HubChat / coach / digest #1726). Можна злити в будь-якому порядку — code-PR не залежить від doc-PR (і навпаки), але порядок merge може створити короткочасний drift у Status-рядку якщо doc-PR смерджиться першим.
  • Pre-existing CI failures на main (governance sync drift, Markdown link checker, Test coverage server apiV1.test.ts, mobile build, E2E auth, Argos visual regression) — не від цього PR; той самий набір на 2.4–2.8.

Summary by cubic

Record PR 2.8 (#1726) for DataState adoption in digest by updating the 0011 initiative doc: add 2.8 to the status header, update the Phase 2 table with core/insights/WeeklyDigestCard.tsx (DigestContent 4‑state ladder), and mark the consumer‑adoption block closed.

Written for commit a675fd3. Summary will update on new commits.

Summary by CodeRabbit

  • Documentation
    • Updated initiative tracking documentation with validation timestamps and expanded progress details for Phase 2 milestones, including implementation specifics for consumer migrations and related development items.

Status header: додано PR 2.8 (#1726) і змінено сигнал з "2.8
HubChat/coach/digest залишається" на "2.9 ESLint rule і 2.1
ManualExpenseSheet залишаються" — consumer-adoption блок Phase 2
закрито.

Phase 2 table row 2.8: ETA "+3 дні" → "Opened 2026-05-04 — #1726",
файл `core/insights/WeeklyDigestCard.tsx` `DigestContent` 4-state
ladder як єдиний Skeleton-based panel-loading site у HubChat /
coach / digest зоні `core/**`.

Footnote: додано пояснення per PR 2.8 чому інші HubChat / coach /
digest "панелі" з пропозиції (`HubChatHistoryPanel`,
`CoachInsightsPanel`, `DigestPanel`) не мали реальних DataState-
targets — `AssistantAdviceCard` без skeleton imports і кешує
last-good insight, `HubChatHistoryDrawer` local-first, `HubChat.tsx`
/ `HubChatBody` / `HubChatComposer` стрімлять без panel-skeleton-у.

Refs initiative 0011 PR 2.8.
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sergeant Ready Ready Preview, Comment May 4, 2026 5:49pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

📝 Walkthrough

Walkthrough

This PR updates the initiative document 0011 by adding validation timestamps, refreshing Phase 1/2 progress tracking in the Status section, and completing the Phase 2.4–2.8 consumer-adoption table with the missing PR 2.8 entry and expanded implementation details for Skeleton-based loading targets.

Changes

Initiative Documentation Update

Layer / File(s) Summary
Metadata & Status
docs/initiatives/0011-foundation-adoption-and-process-discipline.md (lines 3–4)
Added "Last validated" and "Next review" fields; updated Status section with current Phase 1/Phase 2 progress, listing merged and open consumer-adoption PRs.
Consumer-Adoption Table
docs/initiatives/0011-foundation-adoption-and-process-discipline.md (lines 129–137)
Completed Phase 2.4–2.8 <DataState> consumer migrations table by adding PR 2.8 (HubChat/coach/digest); updated follow-up note with actual Skeleton-based loading implementation scope for 2.4–2.8.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

size/S

Poem

🐰 The initiatives now stand complete,
With timelines fresh and metrics neat,
Phase 2 marches on with pride,
Skeleton loaders by our side!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the specific change: documenting DataState adoption PR 2.8 (digest-related work) in initiative 0011, which matches the file update and objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1777916826-0011-progress-2-8

Review rate limit: 2/10 reviews remaining, refill in 42 minutes and 18 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/initiatives/0011-foundation-adoption-and-process-discipline.md`:
- Around line 3-5: Add a lifecycle badge directly under the freshness line that
currently reads "Last validated: 2026-05-04 by `@Skords-01`. Next review:
2026-08-02." — insert a badge-style status indicator (one of Active, Scaffolded,
Deprecated, Archived) on its own line immediately below that freshness marker so
the document shows "Lifecycle: Active" (or the appropriate status) in badge
form; target the same block containing the "Last validated" / freshness marker
in 0011-foundation-adoption-and-process-discipline.md and ensure the badge is
visually separated (its own line) and matches the project's docs badge style.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 09282156-b7e7-4870-92b3-eae211223eaa

📥 Commits

Reviewing files that changed from the base of the PR and between ec1f382 and a675fd3.

📒 Files selected for processing (1)
  • docs/initiatives/0011-foundation-adoption-and-process-discipline.md

Comment on lines 3 to 5
> **Last validated:** 2026-05-04 by @Skords-01. **Next review:** 2026-08-02.
> **Status:** Phase 1 ~70% done (1.1/1.2/1.3 merged; 1.4 pending). Phase 2 in flight: 2.2 merged (#1696); 2.4 (#1703) + 2.5 (#1709) + 2.6 (#1713) + 2.7 (#1714) opened 2026-05-04 (DataState consumer adoption — finyk + fizruk + nutrition + routine; 2.8 HubChat/coach/digest залишається).
> **Status:** Phase 1 ~70% done (1.1/1.2/1.3 merged; 1.4 pending). Phase 2 in flight: 2.2 merged (#1696); 2.4 (#1703) + 2.5 (#1709) + 2.6 (#1713) + 2.7 (#1714) + 2.8 (#1726) opened 2026-05-04 (DataState consumer adoption — finyk + fizruk + nutrition + routine + digest closes the consumer-adoption block; 2.9 ESLint rule і 2.1 ManualExpenseSheet залишаються).
> **Priority:** P1 (subordinate to 0010-revenue-first-launch scope-freeze)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add required lifecycle status badge under the freshness marker.

Please add a badge-style lifecycle marker directly under the freshness line (e.g., Active, Scaffolded, Deprecated, or Archived) to satisfy docs governance for lifecycle signaling.

As per coding guidelines, “Lifecycle markers in documentation: declare status (Active, Scaffolded, Deprecated, Archived) in a status badge under the freshness marker”.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/initiatives/0011-foundation-adoption-and-process-discipline.md` around
lines 3 - 5, Add a lifecycle badge directly under the freshness line that
currently reads "Last validated: 2026-05-04 by `@Skords-01`. Next review:
2026-08-02." — insert a badge-style status indicator (one of Active, Scaffolded,
Deprecated, Archived) on its own line immediately below that freshness marker so
the document shows "Lifecycle: Active" (or the appropriate status) in badge
form; target the same block containing the "Last validated" / freshness marker
in 0011-foundation-adoption-and-process-discipline.md and ensure the badge is
visually separated (its own line) and matches the project's docs badge style.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

⏱️ CI Pipeline Duration Report

Based on the last 50 successful runs on the default branch.

Overall Pipeline

Metric Value
p50 6m 26s
p95 7m 55s
p99 9m 3s
Current run 12m 11s
vs p95 +53.9%

Trend (last 20 runs): ▃▃▁▂▃▃▃▂▃▃▂▂▄▃▃▆▅▄█▆

Per-Job Breakdown

Job p50 p95 p99 Current vs p95
Accessibility (axe-core) 2m 5s 2m 21s 2m 23s 0s -100.0%
Commit messages (commitlint) 0s 0s 0s 39s N/A
Critical-flow E2E (Playwright) 1m 36s 1m 44s 1m 44s 6m 8s +253.8%
Migration lint (AGENTS rule 0s 0s 0s 7s N/A
Pipeline duration (p95 trend) 26s 27s 27s
Secret scan (gitleaks) 8s 11s 11s 8s -27.3%
Smoke E2E (Playwright) 1m 26s 1m 40s 1m 40s
Test coverage (vitest) 2m 4s 2m 33s 2m 33s 2m 17s -10.5%
Workflow lint (actionlint) 7s 7s 7s 4s -42.9%
check 4m 12s 4m 54s 5m 6s 48s -83.7%
tsconfig strict guard (PR-1.A) 5s 14s 14s 5s -64.3%

⚠️ Warning: Current run (12m 11s) exceeds p95 + 20% threshold (9m 30s). Consider reviewing slow jobs.

@Skords-01 Skords-01 merged commit 89d4fc6 into main May 4, 2026
27 of 48 checks passed
@Skords-01 Skords-01 deleted the devin/1777916826-0011-progress-2-8 branch May 4, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants