Skip to content

Use string form for repository field in plugin.json#2

Open
bryan-anthropic wants to merge 1 commit into
SAP-samples:mainfrom
bryan-anthropic:fix/plugin-json-repository-string-form
Open

Use string form for repository field in plugin.json#2
bryan-anthropic wants to merge 1 commit into
SAP-samples:mainfrom
bryan-anthropic:fix/plugin-json-repository-string-form

Conversation

@bryan-anthropic
Copy link
Copy Markdown

The Claude plugin schema (validated by claude plugin validate) requires the repository field to be a string URL, not an npm-style {type, url} object.

When this plugin is referenced from a marketplace and the validate-plugins GitHub Action runs against it, validation fails with:

hana-cli: claude plugin validate failed
  https://github.com/SAP-samples/hana-cli-claude-plugin.git@<sha>
  ❯ repository: Invalid input: expected string, received object

Change

- "repository": {
-   "type": "git",
-   "url": "https://github.com/SAP-samples/hana-cli-claude-plugin"
- },
+ "repository": "https://github.com/SAP-samples/hana-cli-claude-plugin",

This matches the form used by other SAP plugins published to Claude Code marketplaces (e.g. cap-js/mcp-server, SAP/open-ux-tools packages).

No other changes — name, description, author, homepage, license, keywords, and the actual git repository URL all remain identical.

The Claude plugin schema (validated by `claude plugin validate`) requires
the `repository` field to be a string URL, not an npm-style `{type, url}`
object. Submitting this plugin to a marketplace using the validate-plugins
GitHub Action fails today with:

    repository: Invalid input: expected string, received object

Switching to the string form resolves validation and matches the form
used by other SAP plugins (e.g. cap-js/mcp-server, SAP/open-ux-tools).
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 7, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

bryan-anthropic added a commit to anthropics/claude-plugins-official that referenced this pull request May 8, 2026
150+ SAP HANA database tools for AI assistants. Pinned at 160ae47e.

Held: this PR is on hold pending an upstream plugin.json fix in
SAP-samples/hana-cli-claude-plugin#2 (the upstream repo uses the
npm-style {type, url} form for `repository`; Claude's plugin schema
requires the string form).

Once that lands, bump the SHA pin here to the merge commit and re-run CI.

Other SAP namespace work that was previously bundled in this PR has been
split into:
  - #1777 add sap-fiori-mcp-server
  - #1778 add sap-cds-mcp + author block on cds-mcp
  - #1779 align SAP author blocks on sap-mdk-server, ui5, ui5-typescript-conversion
@bryan-anthropic
Copy link
Copy Markdown
Author

Friendly ping on this PR — happy to discuss any concerns or iterate on the change if there's something I can adjust. The string form for repository is what the Claude Code plugin schema validator expects, so this is the blocker for getting sap-hana-cli listed in the official marketplace (PR open at anthropics/claude-plugins-official#1616).

Let me know if there's anything I can do to help move this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant