[19.0][MIG] marketing_card: trivial annotation#5665
Open
dnplkndll wants to merge 1 commit into
Open
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
dnplkndll
changed the title
dnplkndll
force-pushed
the
19.0-mig-marketing-card-trivial
branch
from
36155bb to
65dc654
Compare
dnplkndll
force-pushed
the
19.0-mig-marketing-card-trivial
branch
from
65dc654 to
0a39155
Compare
Author
|
@MiquelRForgeFlow ready ( unblocked by openupgradelib#450). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotation-only coverage for
marketing_card. Split out from #5651 because the OCAtestworkflow was failing on this module via an upstreamopenupgradelibbug.Status
OCA/openupgradelib#450merged 2026-05-21 by @MiquelRForgeFlow. CI re-triggered to pick up the fix (workflow installs openupgradelib from GitHubmain, so the patch propagates automatically).Background (kept for reviewer context)
Adding
marketing_cardtoMODULES_NEWpreviously triggeredopenupgrade.merge_models()'scard_campaigncross-reference UPDATE block, which had two bugs introduced by openupgradelib #436 (Feb 2026): asql.SQL().format()placeholder mismatch (KeyError: 'old_model') and a double-ANDSQL typo. Hit on every model-merge migration when marketing_card is installed — e.g.hr_recruitment/19.0.1.1/pre-migration.py:14'shr.candidate → hr.applicantmerge. Detailed forensics inOCA/openupgradelib#450.Verification trail
19.0-mig-test-marketing-card-isolated— both seeds failed with the exactKeyError: 'old_model'from the openupgradelib helper. Isolation confirmed.OCA/openupgradelib#450merge: CI re-run on this PR (see below for green status).scripts/verify-pr-staged.sh.