[19.0][MIG] hr_*: analyses for simple submodules#5634
Open
dnplkndll wants to merge 1 commit into
Open
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 15, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 15, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 15, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
force-pushed
the
19.0-mig-hr-family-trivial
branch
from
dae82d1 to
802170b
Compare
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 15, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 16, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
force-pushed
the
19.0-mig-hr-family-trivial
branch
from
802170b to
6067bf0
Compare
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 19, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
force-pushed
the
19.0-mig-hr-family-trivial
branch
from
6067bf0 to
c9a3863
Compare
remi-filament
suggested changes
May 20, 2026
Contributor
There was a problem hiding this comment.
Thanks @dnplkndll
Here also you need to handle the noupdate xml
dnplkndll
force-pushed
the
19.0-mig-hr-family-trivial
branch
from
c9a3863 to
f9e80d8
Compare
dnplkndll
changed the title
Author
|
@remi-filament — addressed the noupdate XML feedback in f9e80d8:
Docsource: all 15 rows now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotation-only coverage for 15
hr_*submodules whose 19.0 deltas are either auto-handled by Odoo's standard upgrade flow or require small noupdate-record decisions.In scope (
hr_calendar,hr_fleet,hr_gamification,hr_homeworking,hr_livechat,hr_maintenance,hr_org_chart,hr_presence,hr_recruitment_sms,hr_recruitment_survey,hr_skills_event,hr_skills_slides,hr_skills_survey,hr_timesheet,hr_work_entry_holidays).noupdate decisions:
hr_presence—mail_template_presence(email_to/use_default_to) commented out: preserves operator-customized template settings.hr_recruitment_survey(sibling added) —mail_template_applicant_interview_invitecommented out: preserves operator-customized template body / lang.hr_timesheet— left active: security framework (privilege_id) + ir.ruledomain_forceupdates are migration-required;(4, ref(...))on group user_ids is additive.hr_work_entry_holidays(sibling added) — left active:hr.leave.type→work_entry_type_idFK mapping is structural;forcecreate="0"is defensive.The 4 substantial
hr_*submodules (hr_attendance,hr_skills,hr_recruitment_skills,hr_holidays_attendance) are deferred to #5635 for focused review of the overtime + skills refactor.