Fix: Improve location text alignment on profile page#465
Fix: Improve location text alignment on profile page#465AyushAgrawal18 wants to merge 5 commits into
Conversation
|
Hi, I’ve submitted a PR for this issue. Please review. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the layout of the location section in the bio component, changing it from left-aligned to right-aligned and reducing the gap between the icon and text. The review feedback points out that these changes introduce visual inconsistencies with the rest of the sidebar and suggests using 'items-start' with the original gap size to better handle text wrapping while maintaining a uniform design.
There was a problem hiding this comment.
Pull request overview
Improves the visual alignment of the location/country line on user profile pages by updating the layout classes in the profile bio include.
Changes:
- Adjusted the location row to right-align its content (
justify-end,text-right) and tweaked spacing (gap-2). - Updated the flex row styling to better handle alignment when location text is long.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request modifies the layout of the location field in the bio sidebar, changing it from a left-aligned layout to a right-aligned one with reduced spacing. The review feedback highlights that this change introduces visual inconsistency with other sidebar elements, such as Email and Website, which remain left-aligned. It is recommended to revert these styling changes to maintain a cohesive user interface and ensure proper vertical alignment of the icon.
| <div class="space-y-4 text-sm border-t border-[var(--border-color)] pt-6"> | ||
| {% if location or country %} | ||
| <div class="flex items-center gap-3"> | ||
| <div class="flex justify-end gap-2 text-right"> |
There was a problem hiding this comment.
This change introduces visual inconsistency in the profile sidebar. The location field is now right-aligned (justify-end), while the Email (line 33) and Website (line 41) fields are left-aligned. Furthermore, the reduction in gap (from gap-3 to gap-2) and the removal of items-center (which ensures the icon is vertically centered with the text) deviate from the established pattern in this list. To maintain a cohesive UI, it is recommended to keep the alignment consistent with the other contact details.
<div class="flex items-center gap-3">
Fix
Improved alignment of location text on profile pages.
Changes
Testing