fix(memos-local): include json hint in user messages#1756
Open
de1tydev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix OpenAI-compatible JSON mode requests by ensuring at least one user message contains the word
jsonwhenjsonMode/completeJsonis used.Some OpenAI-compatible gateways and newer OpenAI-style APIs reject
response_format: { type: "json_object" }unless the request input messages contain the wordjson. Previously, the memos LLM client injected the JSON instruction only into the system message. That can still fail on gateways that validate user/input content and return errors like:This change appends a short user-level hint (
Return valid json only.) when JSON mode is active and the existing user message does not already containjson.Changes
ensureJsonWordInUserMessage()incore/llm/client.ts.complete(..., { jsonMode: true })completeJson(...)Testing
From
apps/memos-local-plugin:Both pass locally.