Inline AnyFrame, AnyRow, and AnyBaseCol type aliases in public API#1863
Open
Allex-Nik wants to merge 1 commit into
Open
Inline AnyFrame, AnyRow, and AnyBaseCol type aliases in public API#1863Allex-Nik wants to merge 1 commit into
AnyFrame, AnyRow, and AnyBaseCol type aliases in public API#1863Allex-Nik wants to merge 1 commit into
Conversation
Allex-Nik
commented
May 18, 2026
| @@ -1,11 +1,8 @@ | |||
| package org.jetbrains.kotlinx.dataframe.api | |||
Collaborator
Author
There was a problem hiding this comment.
I've also encountered:
- AnyCol
- Predicate
- ColumnFilter
- AnyColumnReference
- AnyColumnGroupAccessor
- StringCol
- ColumnGroupReference
- ColumnGroupAccessor
Should we inline them/some of them as well?
ColumnFilter, ColumnGroupAccessor, and maybe Predicate are probably fine as they are, but it seems logical to me to inline AnyCol, AnyColumnReference, AnyColumnGroupAccessor, StringCol, ColumnGroupReference for the same reasons as AnyFrame, AnyRow, and AnyBaseCol.
Collaborator
There was a problem hiding this comment.
Sure, feel free to create an issue to continue this task. I only choose these 3 because they're have most usages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #906