Apply korro to samples in data sources#1833
Merged
Merged
Conversation
Collaborator
Author
|
Is the package correct for the samples? Should |
Allex-Nik
commented
Apr 29, 2026
Allex-Nik
commented
Apr 29, 2026
Allex-Nik
commented
Apr 29, 2026
Jolanrensen
approved these changes
Apr 30, 2026
koperagen
reviewed
Apr 30, 2026
koperagen
reviewed
Apr 30, 2026
Collaborator
|
Tables in |
655d665 to
9fe3c6d
Compare
Collaborator
Author
I have done it in these sections (and in some others for consistency) and also added iframes for the results where it seemed useful |
zaleslaw
approved these changes
May 6, 2026
9fe3c6d to
dedd1db
Compare
dedd1db to
6e5af44
Compare
koperagen
approved these changes
May 18, 2026
6e5af44 to
8034fa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds usage of
korroto the samples in the following webpages:Related to #987, but does not change https://kotlinlang.org/docs/data-analysis-connect-to-db.html (as it will be done separately later). In addition, https://kotlin.github.io/dataframe/readsqlfromcustomdatabase.html was already done by @Jolanrensen