fix: address plugin bridge review comments from PR #9889

[jackkav]

Summary

Addresses the review comments left on #9889 after merge.

• IPC channel naming consistency — renamed plugin-ui-alert, plugin-ui-dialog, plugin-ui-prompt, plugin-ui-prompt-result to plugins.uiAlert, plugins.uiDialog, plugins.uiPrompt, plugins.uiPromptResult to match the plugins.xxx dot-notation pattern used by all other plugin bridge channels
• Missing sender check — added event.sender !== mainWindow.webContents guard to the plugins.uiPromptResult IPC handler (the prompt result originates from the main renderer window, not the plugin window)
• getBridgeMetrics consistency — switched from raw invokeWithNormalizedError('plugins.getBridgeMetrics') to invokePluginBridgeMethod('getBridgeMetrics') and added 'getBridgeMetrics' to PluginInvokeMethod
• Bridge executePluginMainAction in root.tsx — replaced direct executePluginMainAction import from ~/plugins with window.main.plugins.executePluginMainAction (the bridge)
• servicesProxy in plugin window — replaced servicesNodeImpl with servicesProxy in entry.plugin-window.ts so service calls route through IPC to the main process rather than importing the Node.js implementation bundle directly

Test plan

• TypeScript: no errors (tsc --noEmit)
• ESLint: no issues

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR follows up on PR #9889 by tightening the plugin-bridge IPC surface: it standardizes plugin UI IPC channel names, adds sender validation for prompt results, routes getBridgeMetrics through the same preload bridge helper, switches plugin-window service initialization to the IPC proxy, and updates an OAuth flow to call plugin main actions via the bridge.

Changes:

• Renamed plugin UI IPC channels to plugins.ui* dot-notation and updated corresponding type unions and listeners.
• Added event.sender === mainWindow.webContents validation for plugins.uiPromptResult.
• Routed plugin-window service calls through servicesProxy and normalized getBridgeMetrics invocation via invokePluginBridgeMethod.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/insomnia/src/ui/renderer-listeners.ts	Updates renderer listeners to new plugins.ui* IPC channel names.
packages/insomnia/src/root.tsx	Switches Azure OAuth exchange to use the plugin bridge call site.
packages/insomnia/src/plugins/invoke-method.ts	Extends PluginInvokeMethod with getBridgeMetrics.
packages/insomnia/src/main/plugin-window.ts	Renames plugin UI channels and adds sender validation for prompt results.
packages/insomnia/src/main/ipc/electron.ts	Updates IPC channel type unions to match the new channel names.
packages/insomnia/src/entry.preload.ts	Uses invokePluginBridgeMethod('getBridgeMetrics') and renames prompt-result send channel.
packages/insomnia/src/entry.plugin-window.ts	Initializes services using servicesProxy instead of the node implementation bundle.
packages/insomnia/src/entry.plugin-window-preload.ts	Renames plugin UI bridge channels used by the plugin window.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

✅ Circular References Report

Generated at: 2026-05-21T07:46:53.416Z
Status: ✅ NO CHANGE

Summary

Metric	Base (develop)	PR	Change
Total Circular References	19	19	0 (0.00%)

Click to view all circular references in PR (19)

insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts -> insomnia/src/script-executor.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts -> insomnia/src/script-executor.ts -> insomnia/src/scripting/require-interceptor.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/concurrency.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts -> insomnia/src/templating/index.ts -> insomnia/src/plugins/index.ts -> insomnia/src/plugins/context/app.ts -> insomnia/src/templating/types.ts -> insomnia/src/plugins/context/network.ts
insomnia/src/network/network.ts -> insomnia/src/main/network/get-auth-header.ts -> insomnia/src/main/network/o-auth-2/get-token.ts
insomnia/src/plugins/index.ts -> insomnia/src/plugins/context/app.ts -> insomnia/src/templating/types.ts -> insomnia/src/plugins/context/store.ts
insomnia/src/plugins/index.ts -> insomnia/src/plugins/misc.ts
insomnia/src/templating/base-extension-worker.ts -> insomnia/src/templating/worker.ts
insomnia/src/templating/index.ts -> insomnia/src/templating/base-extension.ts
insomnia/src/templating/types.ts -> insomnia/src/plugins/context/network.ts
insomnia/src/templating/types.ts -> insomnia/src/templating/utils.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx

Click to view all circular references in base branch (19)

insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts -> insomnia/src/script-executor.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts -> insomnia/src/script-executor.ts -> insomnia/src/scripting/require-interceptor.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/concurrency.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts -> insomnia/src/templating/index.ts -> insomnia/src/plugins/index.ts -> insomnia/src/plugins/context/app.ts -> insomnia/src/templating/types.ts -> insomnia/src/plugins/context/network.ts
insomnia/src/network/network.ts -> insomnia/src/main/network/get-auth-header.ts -> insomnia/src/main/network/o-auth-2/get-token.ts
insomnia/src/plugins/index.ts -> insomnia/src/plugins/context/app.ts -> insomnia/src/templating/types.ts -> insomnia/src/plugins/context/store.ts
insomnia/src/plugins/index.ts -> insomnia/src/plugins/misc.ts
insomnia/src/templating/base-extension-worker.ts -> insomnia/src/templating/worker.ts
insomnia/src/templating/index.ts -> insomnia/src/templating/base-extension.ts
insomnia/src/templating/types.ts -> insomnia/src/plugins/context/network.ts
insomnia/src/templating/types.ts -> insomnia/src/templating/utils.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx

Analysis

✅ No Change: This PR does not introduce or remove any circular references.

---

This report was generated automatically by comparing against the develop branch.