chore: remove konnect sync feature flag#9927
Open
shelby-moore wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the local Konnect Sync feature flag (KONNECT_SYNC_ENABLED / isKonnectSyncEnabled) so Konnect Sync availability is determined solely by organization feature configuration returned from the Insomnia API.
Changes:
- Removed
isKonnectSyncEnabled()from~/common/constantsand its usages. - Updated project routes and Settings modal gating to rely on
features.konnectSync.enabledfrom organization features.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/insomnia/src/ui/components/modals/settings-modal.tsx | Removes the local env-based gate so Konnect tab visibility is driven by org feature response. |
| packages/insomnia/src/routes/organization.$organizationId.project.$projectId._index.tsx | Removes local flag check when passing konnectSyncEnabled to the project sidebar. |
| packages/insomnia/src/routes/organization.$organizationId.project._index.tsx | Same as above for the organization project index route. |
| packages/insomnia/src/common/constants.ts | Deletes the isKonnectSyncEnabled constant helper (env flag removal). |
Comments suppressed due to low confidence (1)
packages/insomnia/src/ui/components/modals/settings-modal.tsx:60
- Now that the local KONNECT_SYNC_ENABLED gate is removed, opening Settings will always make a fresh getOrganizationFeatures() request to determine konnectSync availability. On organization routes this data is already fetched/cached via useOrganizationPermissions (permissions fetcher), so this becomes a redundant network call. Consider sourcing konnectSync.enabled from the shared permissions/features loader (or passing it in) to avoid duplicate requests and keep a single source of truth.
!models.organization.isScratchpadOrganizationId(organizationId)
) {
try {
const res = await getOrganizationFeatures({ organizationId, sessionId: userSession.id });
setShouldShowKonnectTab(res?.features?.konnectSync?.enabled ?? false);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryan-willis
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Konnect integration feature flag, it will become available once this PR is merged.