Skip to content

chore: remove konnect sync feature flag#9927

Open
shelby-moore wants to merge 1 commit into
Kong:developfrom
shelby-moore:chore-remove-konnect-sync-feature-flag
Open

chore: remove konnect sync feature flag#9927
shelby-moore wants to merge 1 commit into
Kong:developfrom
shelby-moore:chore-remove-konnect-sync-feature-flag

Conversation

@shelby-moore
Copy link
Copy Markdown
Contributor

Removes the Konnect integration feature flag, it will become available once this PR is merged.

Copilot AI review requested due to automatic review settings May 15, 2026 17:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the local Konnect Sync feature flag (KONNECT_SYNC_ENABLED / isKonnectSyncEnabled) so Konnect Sync availability is determined solely by organization feature configuration returned from the Insomnia API.

Changes:

  • Removed isKonnectSyncEnabled() from ~/common/constants and its usages.
  • Updated project routes and Settings modal gating to rely on features.konnectSync.enabled from organization features.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/insomnia/src/ui/components/modals/settings-modal.tsx Removes the local env-based gate so Konnect tab visibility is driven by org feature response.
packages/insomnia/src/routes/organization.$organizationId.project.$projectId._index.tsx Removes local flag check when passing konnectSyncEnabled to the project sidebar.
packages/insomnia/src/routes/organization.$organizationId.project._index.tsx Same as above for the organization project index route.
packages/insomnia/src/common/constants.ts Deletes the isKonnectSyncEnabled constant helper (env flag removal).
Comments suppressed due to low confidence (1)

packages/insomnia/src/ui/components/modals/settings-modal.tsx:60

  • Now that the local KONNECT_SYNC_ENABLED gate is removed, opening Settings will always make a fresh getOrganizationFeatures() request to determine konnectSync availability. On organization routes this data is already fetched/cached via useOrganizationPermissions (permissions fetcher), so this becomes a redundant network call. Consider sourcing konnectSync.enabled from the shared permissions/features loader (or passing it in) to avoid duplicate requests and keep a single source of truth.
        !models.organization.isScratchpadOrganizationId(organizationId)
      ) {
        try {
          const res = await getOrganizationFeatures({ organizationId, sessionId: userSession.id });
          setShouldShowKonnectTab(res?.features?.konnectSync?.enabled ?? false);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants