Skip to content

feat(events): add events for request creation and preferences - INS-2376#9911

Draft
ihexxa wants to merge 4 commits into
developfrom
chore/req-events
Draft

feat(events): add events for request creation and preferences - INS-2376#9911
ihexxa wants to merge 4 commits into
developfrom
chore/req-events

Conversation

@ihexxa
Copy link
Copy Markdown
Contributor

@ihexxa ihexxa commented May 11, 2026

Changes

  • Add the event "AppMenuPreferencesClicked" and the trigger
  • Add triggers for request creation

https://konghq.atlassian.net/browse/INS-2376

@ihexxa ihexxa self-assigned this May 11, 2026
@ihexxa ihexxa changed the title chore(events): add events for request creation and preferences chore(events): add events for request creation and preferences - INS-2376 May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

✅ Circular References Report

Generated at: 2026-05-19T08:40:20.806Z
Status: ✅ NO CHANGE

Summary

Metric Base (develop) PR Change
Total Circular References 19 19 0 (0.00%)
Click to view all circular references in PR (19)
insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts -> insomnia/src/script-executor.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts -> insomnia/src/script-executor.ts -> insomnia/src/scripting/require-interceptor.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/concurrency.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts -> insomnia/src/templating/index.ts -> insomnia/src/plugins/index.ts -> insomnia/src/plugins/context/app.ts -> insomnia/src/templating/types.ts -> insomnia/src/plugins/context/network.ts
insomnia/src/network/network.ts -> insomnia/src/main/network/get-auth-header.ts -> insomnia/src/main/network/o-auth-2/get-token.ts
insomnia/src/plugins/index.ts -> insomnia/src/plugins/context/app.ts -> insomnia/src/templating/types.ts -> insomnia/src/plugins/context/store.ts
insomnia/src/plugins/index.ts -> insomnia/src/plugins/misc.ts
insomnia/src/templating/base-extension-worker.ts -> insomnia/src/templating/worker.ts
insomnia/src/templating/index.ts -> insomnia/src/templating/base-extension.ts
insomnia/src/templating/types.ts -> insomnia/src/plugins/context/network.ts
insomnia/src/templating/types.ts -> insomnia/src/templating/utils.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx
Click to view all circular references in base branch (19)
insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts -> insomnia/src/script-executor.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/cancellation.ts -> insomnia/src/script-executor.ts -> insomnia/src/scripting/require-interceptor.ts
insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts -> insomnia/src/network/network.ts -> insomnia/src/network/concurrency.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts -> insomnia/src/templating/index.ts -> insomnia/src/plugins/index.ts -> insomnia/src/plugins/context/app.ts -> insomnia/src/templating/types.ts -> insomnia/src/plugins/context/network.ts
insomnia/src/network/network.ts -> insomnia/src/main/network/get-auth-header.ts -> insomnia/src/main/network/o-auth-2/get-token.ts
insomnia/src/plugins/index.ts -> insomnia/src/plugins/context/app.ts -> insomnia/src/templating/types.ts -> insomnia/src/plugins/context/store.ts
insomnia/src/plugins/index.ts -> insomnia/src/plugins/misc.ts
insomnia/src/templating/base-extension-worker.ts -> insomnia/src/templating/worker.ts
insomnia/src/templating/index.ts -> insomnia/src/templating/base-extension.ts
insomnia/src/templating/types.ts -> insomnia/src/plugins/context/network.ts
insomnia/src/templating/types.ts -> insomnia/src/templating/utils.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx

Analysis

No Change: This PR does not introduce or remove any circular references.


This report was generated automatically by comparing against the develop branch.

@ihexxa ihexxa changed the title chore(events): add events for request creation and preferences - INS-2376 feat(events): add events for request creation and preferences - INS-2376 May 11, 2026
@ihexxa ihexxa force-pushed the chore/req-events branch 6 times, most recently from 14f53c2 to 5512818 Compare May 18, 2026 07:10
@ihexxa ihexxa requested a review from a team May 18, 2026 07:30
@ihexxa ihexxa marked this pull request as ready for review May 18, 2026 07:31
Copilot AI review requested due to automatic review settings May 18, 2026 07:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds analytics instrumentation for two user actions: clicking the "Preferences" entry in the App menu, and creating new requests through three different entry points (sidebar "+" menu, tab list, and the "Add Request to Collection" modal). It defines a new AppMenuPreferencesClicked analytics event and introduces a makeRequestCreatedEvent helper that emits the existing requestCreated event with requestType and source properties.

Changes:

  • Add AppMenuPreferencesClicked enum value and fire it from the Electron main process menu handler.
  • Add makeRequestCreatedEvent factory in ui/analytics.ts and wire it into the sidebar request creation menu, tab list "+ HTTP request" action, and the add-request-to-collection modal.
  • Convert AnalyticsEvent import in ui/analytics.ts from a type-only to a value import so it can be referenced at runtime.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/insomnia-analytics/src/events.ts Adds the new AppMenuPreferencesClicked enum value.
packages/insomnia/src/main/window-utils.ts Tracks the new event when the Preferences menu item is clicked.
packages/insomnia/src/ui/analytics.ts Adds the makeRequestCreatedEvent factory and switches AnalyticsEvent to a value import.
packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.debug.tsx Tracks request creation for each request type from the sidebar new-request menu.
packages/insomnia/src/ui/components/tabs/tab-list.tsx Tracks HTTP request creation triggered from the tab list.
packages/insomnia/src/ui/components/modals/add-request-to-collection-modal.tsx Tracks HTTP request creation triggered from the add-request modal (source value appears incorrect).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/insomnia/src/ui/components/modals/add-request-to-collection-modal.tsx Outdated
@ihexxa ihexxa marked this pull request as draft May 18, 2026 09:29
@ihexxa ihexxa force-pushed the chore/req-events branch from ed7d266 to f9b271f Compare May 19, 2026 08:21
@ihexxa ihexxa force-pushed the chore/req-events branch from f9b271f to 1c693fd Compare May 19, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants