You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current isequal won't work in a Dict because it violates the principle that isequal(a, b) implies hash(a) == hash(b). This is corrected to not special case empty intervals (unlike == where this makes perfect sense).
I also provide an isless function so that intervals can be sorted stabily and so-on.
The alternative of course would be to add a check for empty closed intervals in hash (and update isless accordingly). However, I think performance of Dict and sort might be slightly better with the approach here.
This came while I was traveling without internet, sorry it didn't get attention until now.
I understand your point about Dict performance, but I kind of think that the docstring implies that isequal is more "permissive," especially about missing values, than ==. Since an empty interval is kind of like a missing value, I worry this is counter to expectations. Consequently I would favor adding the check to hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
isequalwon't work in aDictbecause it violates the principle thatisequal(a, b)implieshash(a) == hash(b). This is corrected to not special case empty intervals (unlike==where this makes perfect sense).I also provide an
islessfunction so that intervals can besorted stabily and so-on.