Skip to content

feat: add findings panel in gitguardian sidebar#137

Open
6d7a wants to merge 1 commit into
mainfrom
6d7a/findings-panel
Open

feat: add findings panel in gitguardian sidebar#137
6d7a wants to merge 1 commit into
mainfrom
6d7a/findings-panel

Conversation

@6d7a
Copy link
Copy Markdown
Contributor

@6d7a 6d7a commented May 4, 2026

Context

Findings from ggshield scans are currently only surfaced in the Problems panel and inline as squiggles. There is no consolidated view of secrets detected across the open workspace.

What has been done

  • add a "Findings" tree view in the GitGuardian sidebar, grouping detected secrets by file. Clicking a finding jumps to its location
  • add a gitguardian.refreshFindings title-bar action to manually rebuild the list
  • clear the diagnostic collection for a file when a re-scan finishes with no findings, so resolved secrets disappear from the editor and the new tree view
  • export extractInfosFromMessage from the hover provider so the tree can reuse it to label findings by detector

Validation

  • run the extension
  • open a repository that contains an inline secret detected by ggshield
  • ensure the new "Findings" view in the GitGuardian sidebar lists the file with a secret count, and that expanding it shows one entry per finding labelled with the detector
  • click an entry and ensure the editor jumps to the matching range
  • remove the secret from the file and save
  • ensure the file disappears from the "Findings" view and the inline squiggle is cleared

PR check list

  • As much as possible, the changes include tests
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry.

@6d7a 6d7a requested a review from a team as a code owner May 4, 2026 08:22
Comment thread src/gitguardian-interface/gitguardian-findings-tree.ts Outdated
Comment thread src/lib/ggshield-api.ts
@6d7a 6d7a force-pushed the 6d7a/findings-panel branch from 5d9fcc2 to abd44d1 Compare May 15, 2026 13:20
@6d7a 6d7a requested a review from clement-tourriere May 18, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants