chore: tooling updates#125
Open
GabrielCousin wants to merge 9 commits into
Open
Conversation
e9a501b to
b6e0130
Compare
67cad5e to
2a06255
Compare
290e04a to
6e2b983
Compare
Member
Author
Code reviewFound 2 issues:
gitguardian-vscode/package.json Lines 175 to 178 in 6e2b983 gitguardian-vscode/tsconfig.test.json Lines 1 to 9 in 6e2b983
gitguardian-vscode/.github/workflows/ci.yaml Lines 19 to 25 in 6e2b983 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
- npm and github-actions ecosystems, monthly schedule - 3-day cooldown on all updates (supply-chain protection) - Groups: typescript-eslint, vscode Refs: FRNT-1207
- Replace actions/setup-node@v4 (hardcoded versions) with mise-action@v2 so CI picks up the Node version from .mise.toml - Switch yarn → npm ci for installs - Update vsce install to @vscode/vsce (current package name) - Remove XQuartz install step (handled in next commit with test-cli) Refs: FRNT-1209
Split tsconfig.json into a solution-style config referencing tsconfig.src.json (extension source) and tsconfig.test.json (tests, adds mocha types). Explicit types fields ensure @types/node and @types/mocha are reliably resolved by both tsc and VS Code. Update compile, compile-tests, check, and watch scripts accordingly. ESLint parserOptions now reference both concrete configs.
6e2b983 to
4567cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of developer tooling and CI modernisation tasks, grouped into 9 thematic commits:
chore: clean up docs and add issue templates— Lowercase.MD→.mddoc extensions; remove stale duplicate bug-report template; add feature-request issue template.chore: update pre-commit, pin Node 22, and switch to npm— Update ggshield pre-commit pin to v1.49.0; pin Node 22 via.mise.toml; declareengines.node >= 20; switch from Yarn to npm with.npmrc.chore: add Dependabot config with monthly schedule and cooldown— Add monthly Dependabot schedule with grouping/cooldown.chore: migrate CI to jdx/mise-action@v2 and npm— Migrate tomise-action@v2; drop globalvsceinstall in favour ofnpx; fix test matrix for all platforms.chore(test): migrate to @vscode/test-cli, sinon, and mocha v11— Replace legacyrunTest.ts/suite/index.tswith@vscode/test-cli(.vscode-test.mjs); replacesimple-mockwithsinon; upgrade Mocha to v11; addchildProcessabstraction for stubbing.chore: migrate ESLint to v9 flat config and enforce strict types— Migrate from.eslintrc.jsonto ESLint v9 flat config (eslint.config.mjs) +typescript-eslintv8; enforceno-explicit-any; replace remaininganytypes with proper types acrosssrc/.fix: use correct 'supported' key for untrustedWorkspaces capability— Fix typo inpackage.jsoncapabilities declaration.chore: restructure tsconfig with explicit src/test projects— Split tsconfig into explicitsrc/andtest/project references.chore: add esbuild bundler and consolidate output to dist/— Bundle extension with esbuild; consolidate output todist/; update.vscodeignoreaccordingly.Test plan
npm installsucceeds from a clean checkoutnpm run lintpasses with no errorsnpm run compilesucceeds@vscode/test-clirunner