Skip to content

Fix #88730: show invite-as-user row for unknown emails in SearchRouter #89405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
15antonian wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix #88730: show invite-as-user row for unknown emails in SearchRouter #89405

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f927a6
Fix #88730: show Invite label for unknown-email results in SearchRouter
15antonian Apr 24, 2026
5736165
Add regression tests for canCreateOptimisticPersonalDetailOption #88730
15antonian May 1, 2026
d175665
Address Codex P1: also match raw E.164 logins in canCreateOptimisticP…
15antonian May 6, 2026
6a3c619
Merge remote-tracking branch 'origin/main' into fix/88730-search-invi…
15antonian May 18, 2026
d236d83
Add test: invite row shows "Invite" alternateText for unknown email i…
15antonian May 19, 2026
f0db258
Add UI test: invite row alternateText covered in SearchAutocompleteList
15antonian May 19, 2026
126cb5e
Fix ESLint: explicit props on SearchQueryListItem, remove stale disab…
15antonian May 20, 2026
27abac1
Revert SearchAutocompleteList to spread props; keep test file ESLint fix
15antonian May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Search/SearchAutocompleteList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,11 +367,11 @@ function SearchAutocompleteList({

const reportOptions: OptionData[] = [...orderedOptions.recentReports, ...orderedOptions.personalDetails];
if (searchOptions.userToInvite) {
reportOptions.push(searchOptions.userToInvite);
reportOptions.push({...searchOptions.userToInvite, alternateText: translate('common.invite')});
}

return reportOptions.slice(0, 20);
}, [autocompleteQueryValue, searchOptions]);
}, [autocompleteQueryValue, searchOptions, translate]);

const debounceHandleSearch = useDebounce(() => {
if (!handleSearch || !autocompleteQueryWithoutFilters) {
Expand Down
7 changes: 5 additions & 2 deletions src/libs/OptionsListUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,13 +1922,16 @@ function canCreateOptimisticPersonalDetailOption({
currentUserOption?: SearchOptionData | null;
searchValue: string;
}) {
if (recentReportOptions.length + personalDetailsOptions.length > 0) {
const normalizedSearchValue = addSMSDomainIfPhoneNumber(searchValue ?? '').toLowerCase();
const hasExactLoginMatch =
recentReportOptions.some((o) => o.login?.toLowerCase() === normalizedSearchValue) || personalDetailsOptions.some((o) => o.login?.toLowerCase() === normalizedSearchValue);
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Compare raw phone logins before adding invite row

The new exact-match gate only compares option logins against addSMSDomainIfPhoneNumber(searchValue), which misses existing contacts whose login is stored as raw E.164 (e.g. +15005550006 without @expensify.sms). In that case, typing that exact phone number still passes canCreateOptimisticPersonalDetailOption, so userToInvite is created even though an exact contact already exists, yielding a duplicate/inaccurate “Invite” result. This regression is reachable in flows where phone logins are kept without the SMS suffix.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach ZhenjaHorbach May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach ZhenjaHorbach May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@15antonian
Check this comment please

Copy link
Copy Markdown
Author

@15antonian 15antonian May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, addressed. Updated canCreateOptimisticPersonalDetailOption to also match logins stored as raw E.164 (no @expensify.sms suffix), and added two regression tests covering both storage formats. Existing tests still pass.

if (hasExactLoginMatch) {
return false;
}
if (!currentUserOption) {
return true;
}
return currentUserOption.login !== addSMSDomainIfPhoneNumber(searchValue ?? '').toLowerCase() && currentUserOption.login !== searchValue?.toLowerCase();
return currentUserOption.login !== normalizedSearchValue && currentUserOption.login !== searchValue?.toLowerCase();
}

/**
Expand Down
Loading
Loading