fix(prover): populate CongloVK and VKMerkleRoot in invalidity limitle…#3150
Merged
Conversation
…ss circuit The limitless invalidity builder was not extracting verification key data from congWIOP.ExtraData, leaving CongloVK and VKMerkleRoot as zero-valued constants in the compiled constraint system. At prove time, the actual VK values from the conglomeration proof failed the assertIsEqual check against these zero constants. Extract VK octuplets from ExtraData (matching the execution limitless builder pattern) and pass vkMerkleRoot through from setup.
Contributor
coordinator Changelog Preview (informational)[Unreleased] diff (commits touching
|
Contributor
postman Changelog Preview (informational)[Unreleased] diff (commits touching
|
Contributor
prover Changelog Preview (informational)[Unreleased] diff (commits touching
|
Contributor
tx-exclusion-api Changelog Preview (informational)[Unreleased] diff (commits touching
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limitless invalidity builder was not extracting verification key data from congWIOP.ExtraData, leaving CongloVK and VKMerkleRoot as zero-valued constants in the compiled constraint system. At prove time, the actual VK values from the conglomeration proof failed the assertIsEqual check against these zero constants.
Extract VK octuplets from ExtraData (matching the execution limitless builder pattern) and pass vkMerkleRoot through from setup.
This PR implements issue(s) #
Checklist
PR.
Note
Medium Risk
Touches proof-critical wiring for the limitless invalidity circuit by changing how verifying-key data is injected into the compiled constraint system; a mismatch can break proving/verification but the change is small and localized.
Overview
Fixes the limitless invalidity circuit compilation to embed the correct verifying-key inputs instead of zero-valued constants.
invalidity.NewBuilderLimitlessnow accepts and threads avkMerkleRoot, andCompile()extracts the two conglomeration VK octuplets fromcongWIOP.ExtraData(viadistributedkeys) to populateExecutionCtx.CongloVKandExecutionCtx.VKMerkleRoot. The setup command is updated to load (or derive) the VK Merkle root from execution-limitless assets and pass it into the invalidity limitless builder.Reviewed by Cursor Bugbot for commit 82765cb. Bugbot is set up for automated code reviews on this repo. Configure here.