Skip to content

fix(prover): populate CongloVK and VKMerkleRoot in invalidity limitle…#3150

Merged
gusiri merged 1 commit into
prover/fix-ftxfrom
prover/fix-invalidity-limitless-vk
May 20, 2026
Merged

fix(prover): populate CongloVK and VKMerkleRoot in invalidity limitle…#3150
gusiri merged 1 commit into
prover/fix-ftxfrom
prover/fix-invalidity-limitless-vk

Conversation

@gusiri
Copy link
Copy Markdown
Contributor

@gusiri gusiri commented May 19, 2026

The limitless invalidity builder was not extracting verification key data from congWIOP.ExtraData, leaving CongloVK and VKMerkleRoot as zero-valued constants in the compiled constraint system. At prove time, the actual VK values from the conglomeration proof failed the assertIsEqual check against these zero constants.

Extract VK octuplets from ExtraData (matching the execution limitless builder pattern) and pass vkMerkleRoot through from setup.

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • If this change is deployed to any environment (including Devnet), E2E test coverage exists or is included in this
    PR.
  • I have informed the team of any breaking changes if there are any.

Note

Medium Risk
Touches proof-critical wiring for the limitless invalidity circuit by changing how verifying-key data is injected into the compiled constraint system; a mismatch can break proving/verification but the change is small and localized.

Overview
Fixes the limitless invalidity circuit compilation to embed the correct verifying-key inputs instead of zero-valued constants.

invalidity.NewBuilderLimitless now accepts and threads a vkMerkleRoot, and Compile() extracts the two conglomeration VK octuplets from congWIOP.ExtraData (via distributed keys) to populate ExecutionCtx.CongloVK and ExecutionCtx.VKMerkleRoot. The setup command is updated to load (or derive) the VK Merkle root from execution-limitless assets and pass it into the invalidity limitless builder.

Reviewed by Cursor Bugbot for commit 82765cb. Bugbot is set up for automated code reviews on this repo. Configure here.

…ss circuit

The limitless invalidity builder was not extracting verification key data
from congWIOP.ExtraData, leaving CongloVK and VKMerkleRoot as zero-valued
constants in the compiled constraint system. At prove time, the actual VK
values from the conglomeration proof failed the assertIsEqual check against
these zero constants.

Extract VK octuplets from ExtraData (matching the execution limitless
builder pattern) and pass vkMerkleRoot through from setup.
@gusiri gusiri requested a deployment to docker-build-and-e2e May 19, 2026 09:56 — with GitHub Actions Waiting
@github-actions
Copy link
Copy Markdown
Contributor

coordinator Changelog Preview (informational)

[Unreleased] diff (commits touching coordinator/** since latest releases/coordinator/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

postman Changelog Preview (informational)

[Unreleased] diff (commits touching postman/** since latest releases/postman/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

prover Changelog Preview (informational)

[Unreleased] diff (commits touching prover/** since latest releases/prover/v* tag)

[unreleased]

🐛 Bug Fixes

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

tx-exclusion-api Changelog Preview (informational)

[Unreleased] diff (commits touching tx-exclusion-api/** since latest releases/tx-exclusion-api/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@gusiri gusiri merged commit 3e1ffae into prover/fix-ftx May 20, 2026
73 of 78 checks passed
@gusiri gusiri deleted the prover/fix-invalidity-limitless-vk branch May 20, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant