Skip to content

[ZkcTracer] feat: simple zkc program that compiles to a binary file which is then…#3135

Merged
amkCha merged 8 commits into
mainfrom
feat/simple-zkc-pg-binary-compilation-and-check-CI
May 18, 2026
Merged

[ZkcTracer] feat: simple zkc program that compiles to a binary file which is then…#3135
amkCha merged 8 commits into
mainfrom
feat/simple-zkc-pg-binary-compilation-and-check-CI

Conversation

@amkCha
Copy link
Copy Markdown
Contributor

@amkCha amkCha commented May 18, 2026

… go-corset check against a json input file

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • If this change is deployed to any environment (including Devnet), E2E test coverage exists or is included in this
    PR.
  • I have informed the team of any breaking changes if there are any.

Note

Low Risk
Low risk: adds a new CI workflow and Makefile targets for compiling/executing a small test ZKC program, without changing production logic.

Overview
Adds a new GitHub Actions workflow (arithmetization-simple-zkc-binary-run-and-go-corset-check.yml) that installs zkc, compiles a small ZKC program into a binary, and runs zkc exec --check against a JSON input on PRs/pushes affecting arithmetization.

Updates arithmetization/Makefile to make ZKC inputs configurable via env vars, and introduces zkc-check/zkc-compile-and-check targets.

Adds a minimal simple_add.zkc and matching simple_add.json fixture used by the CI check.

Reviewed by Cursor Bugbot for commit 4d4ec69. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

prover Changelog Preview (informational)

[Unreleased] diff (commits touching prover/** since latest releases/prover/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

linea-besu Changelog Preview (informational)

[Unreleased] diff (commits touching linea-besu/** since latest releases/linea-besu/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

postman Changelog Preview (informational)

[Unreleased] diff (commits touching postman/** since latest releases/postman/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

coordinator Changelog Preview (informational)

[Unreleased] diff (commits touching coordinator/** since latest releases/coordinator/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

tx-exclusion-api Changelog Preview (informational)

[Unreleased] diff (commits touching tx-exclusion-api/** since latest releases/tx-exclusion-api/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

Comment thread .github/workflows/arithmetization-zkc-riscv-check-compilation copy.yml Outdated
Comment thread .github/workflows/arithmetization-zkc-riscv-check-compilation copy.yml Outdated
Comment thread .github/workflows/arithmetization-zkc-riscv-check-compilation copy.yml Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 4 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b50f8b7. Configure here.

Comment thread .github/workflows/arithmetization-simple-zkc-binary-run-and-go-corset-check.yml Outdated
Comment thread .github/workflows/arithmetization-simple-zkc-binary-run-and-go-corset-check.yml Outdated
Copy link
Copy Markdown
Contributor

@lorenzogentile404 lorenzogentile404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amkCha amkCha merged commit 134a330 into main May 18, 2026
47 checks passed
@amkCha amkCha deleted the feat/simple-zkc-pg-binary-compilation-and-check-CI branch May 18, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants