RISCV - integrate zkc pipeline into prover#3132
Open
AlexandreBelling wants to merge 9 commits into
Open
Conversation
This updates the zkcdriver package to use the new ZkC API provided by go-corset. Whilst many things remain the same, there are a few notable differences. Firstly, we no longer read in an LT trace file but, instead, read in a set of "program inputs" (currently as a JSON file, though this could be changed later). The inputs are used to populate the input memories of the ZkC program under consideration. Secondly, there are now the notions of a "static reference table" and a "native module". The former indicates a modules whose contents are fixed across all executions of the given program (i.e. they never change). The latter represent modules which are visible in ZkC, but whose constraints are implemented natively by the prover.
This adds an (incomplete) example test which currently fails when constructing the ZkcDriver for reasons unknown.
This updates the version of go-corset to the latest released version (1.2.16); it also adds a second test which utilises a loop to calculate 2^n.
AlexandreBelling
requested review from
DavePearce,
Soleimani193,
Tabaie,
ThomasPiellard,
YaoJGalteland,
amkCha,
arijitdutta67,
bogdanbear and
ivokub
AlexandreBelling
added
Arithmetization
AlexandreBelling
changed the title
Contributor
linea-besu Changelog Preview (informational)[Unreleased] diff (commits touching
|
Contributor
postman Changelog Preview (informational)[Unreleased] diff (commits touching
|
Contributor
tx-exclusion-api Changelog Preview (informational)[Unreleased] diff (commits touching
|
Contributor
coordinator Changelog Preview (informational)[Unreleased] diff (commits touching
|
Contributor
prover Changelog Preview (informational)[Unreleased] diff (commits touching
|
| continue | ||
| } | ||
|
|
||
| if modDecl.IsNative() { |
Contributor
Author
There was a problem hiding this comment.
@ivokub @YaoJGalteland @Tabaie @arijitdutta67
This is meant to serve as entrypoint for the implementation of the precompiles, when they get added
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
DavePearce
previously approved these changes
May 18, 2026
…riscv---integrate-zkc-pipeline-into-prover
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 99e3fa5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the output of corset-zkC with the prover.
The PR importantly:
Checklist
Note
Medium Risk
Changes how ZkC constraints are loaded/traced and how modules/constraints are materialized into the prover, which can affect soundness and correctness of generated proofs. Adds new handling for static modules and range checks plus dependency bump, so regressions are possible if schemas differ or native modules appear.
Overview
Switches the
zkcdriverpipeline from reading.lttrace files + compilingzkevm.binto reading a binary constraints file and generating the expanded trace directly viaBinaryFile.Trace()from JSON inputs (optionally gzipped), with simplified metadata handling and updated assignment (AssignFromTrace).Adds schema support for static modules by creating sized WIOP modules populated with
NewPrecomputedColumnassignments fromStaticContents(), and implementsair.RangeConstrainttranslation into WIOPNewRangeCheckqueries (while explicitly panicking onIsNative()modules). Also tightensModule.NewPrecomputedColumnto reject promised assignments and sets the assignment promise to the new column view.Bumps
go-corsettov1.2.17and replaces the old skipped definition test with runnable ZkC example tests plus small.zkcfixtures and constraint checks.Reviewed by Cursor Bugbot for commit 99e3fa5. Bugbot is set up for automated code reviews on this repo. Configure here.