Skip to content

[ZkTracer] Add several blake test cases#3117

Merged
lorenzogentile404 merged 25 commits into
mainfrom
3116-zktracer-add-more-blake-test-cases
May 18, 2026
Merged

[ZkTracer] Add several blake test cases#3117
lorenzogentile404 merged 25 commits into
mainfrom
3116-zktracer-add-more-blake-test-cases

Conversation

@lorenzogentile404
Copy link
Copy Markdown
Contributor

@lorenzogentile404 lorenzogentile404 commented May 15, 2026

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • If this change is deployed to any environment (including Devnet), E2E test coverage exists or is included in this
    PR.
  • I have informed the team of any breaking changes if there are any.

Note

Low Risk
Low risk: changes are confined to the RISC-V example/test harness (Makefile/docs) and add/commit test fixtures, with no impact on production runtime code.

Overview
Adds a new make blake-all target in arithmetization/src/test/examples/Makefile to iterate over input vectors from rust/src/blake/blake.all and run blake_with_in_bytes.rs for each case.

Updates the examples README.md accordingly (including the shell alias rename to riscv-test) and commits a large set of generated single-opcode RV64IM assembly test programs under asm/src/op/ by removing the previous ignore rule; the old opcode-test generation/runner scripts under asm/scripts/ are deleted.

Reviewed by Cursor Bugbot for commit d0a782c. Bugbot is set up for automated code reviews on this repo. Configure here.

@lorenzogentile404 lorenzogentile404 linked an issue May 15, 2026 that may be closed by this pull request
6 tasks
@lorenzogentile404 lorenzogentile404 requested a review from amkCha May 15, 2026 10:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

linea-besu Changelog Preview (informational)

[Unreleased] diff (commits touching linea-besu/** since latest releases/linea-besu/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

postman Changelog Preview (informational)

[Unreleased] diff (commits touching postman/** since latest releases/postman/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

coordinator Changelog Preview (informational)

[Unreleased] diff (commits touching coordinator/** since latest releases/coordinator/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

tx-exclusion-api Changelog Preview (informational)

[Unreleased] diff (commits touching tx-exclusion-api/** since latest releases/tx-exclusion-api/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

prover Changelog Preview (informational)

[Unreleased] diff (commits touching prover/** since latest releases/prover/v* tag)

[unreleased]

Generated by git-cliff-action using cliff.toml. This comment is informational and does not gate the PR.

Comment thread arithmetization/src/test/examples/rust/src/blake/run_blake2f_all.sh Outdated
Comment thread arithmetization/src/test/examples/rust/src/blake/Makefile Outdated
@lorenzogentile404 lorenzogentile404 requested a review from amkCha May 18, 2026 09:19
Comment thread arithmetization/src/test/examples/asm/src/op/op_add.s
Comment thread arithmetization/src/test/examples/rust/src/blake/Makefile Outdated
@lorenzogentile404 lorenzogentile404 requested a review from amkCha May 18, 2026 11:13
Signed-off-by: Lorenzo Gentile <lorenzo.gentile@consensys.net>
Comment thread arithmetization/src/test/examples/rust/src/blake/Makefile Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2b0d5c3. Configure here.

Comment thread arithmetization/src/test/examples/Makefile Outdated
@lorenzogentile404 lorenzogentile404 merged commit c58e408 into main May 18, 2026
46 checks passed
@lorenzogentile404 lorenzogentile404 deleted the 3116-zktracer-add-more-blake-test-cases branch May 18, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ZkTracer] Add more blake test cases

2 participants