Skip to content

fix(prover): remove global overwrite in FullZKEVMWithSuite #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gusiri merged 2 commits into from
May 18, 2026
+21 −2
Merged

fix(prover): remove global overwrite in FullZKEVMWithSuite #3114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dc0e58
fix(prover): remove global overwrite in FullZKEVMWithSuite causing ni…
gusiri May 15, 2026
783eb17
test(prover): add test to ensure FullZKEVMWithSuite does not overwrit…
gusiri May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions prover/zkevm/full.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,5 @@ func FullZKEVMWithSuite(
}

// Initialize the Full zkEVM arithmetization
fullZkEvm = NewZkEVM(settings)
return fullZkEvm
return NewZkEVM(settings)
}
Comment on lines 416 to 418
20 changes: 20 additions & 0 deletions prover/zkevm/zkevm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,23 @@ func TestCanGenerateFullZkEVM(t *testing.T) {

_ = FullZkEvm(&cfg.TracesLimits, cfg)
}

// FullZKEVMWithSuite must not overwrite memoized globals.
func TestFullZKEVMWithSuiteNoGlobalOverwrite(t *testing.T) {
cfg, err := config.NewConfigFromFileUnchecked("../config/config-mainnet-limitless.toml")
if err != nil {
t.Fatal(err)
}

sentinel := &ZkEvm{}
original := fullZkEvm
fullZkEvm = sentinel

_ = FullZKEVMWithSuite(&cfg.TracesLimits, cfg, dummyCompilationSuite, nil)

if fullZkEvm != sentinel {
t.Fatal("FullZKEVMWithSuite overwrote the fullZkEvm global")
}

fullZkEvm = original
}
Loading