Skip to content

fix: Patch puppeteer for missing session IDs#2035

Closed
wolfib wants to merge 1 commit into
mainfrom
lighthouse-audit-fix
Closed

fix: Patch puppeteer for missing session IDs#2035
wolfib wants to merge 1 commit into
mainfrom
lighthouse-audit-fix

Conversation

@wolfib
Copy link
Copy Markdown
Contributor

@wolfib wolfib commented May 11, 2026

No description provided.

@wolfib wolfib changed the title Patch puppeteer for missing session IDs fix: Patch puppeteer for missing session IDs May 11, 2026
Comment thread src/puppeteer-patches.ts
type InternalCallbackRegistry as CallbackRegistry,
} from './third_party/index.js';

// 1. Map active command IDs directly to their sessionId
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a reason for the lighthouse timeouts? sounds like it would be easier to fix in Puppeter?

@OrKoN
Copy link
Copy Markdown
Collaborator

OrKoN commented May 18, 2026

@wolfib can you confirm that the issue is fixed?

@wolfib
Copy link
Copy Markdown
Contributor Author

wolfib commented May 18, 2026

The issue isn't fully fixed yet, I'm currently on it.

@OrKoN OrKoN closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants