Skip to content

Azure Local Rack Enabled Deployment Template for ALDO#14772

Merged
alex-frankel merged 1 commit into
Azure:masterfrom
shuklaprakhar415:user/prakshukla/aldoRack
May 18, 2026
Merged

Azure Local Rack Enabled Deployment Template for ALDO#14772
alex-frankel merged 1 commit into
Azure:masterfrom
shuklaprakhar415:user/prakshukla/aldoRack

Conversation

@shuklaprakhar415
Copy link
Copy Markdown
Contributor

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@azure-quickstarts azure-quickstarts added manual validation required This PR requires manual validation readme violations README violations during PR best practices violations BPA labels May 16, 2026
@alex-frankel
Copy link
Copy Markdown
Contributor

Hi @shuklaprakhar415 — thanks for the contribution. One blocker on the structural check:

metadata.json is missing the required testResult field. The Validate – ... job is failing with:

❌ Required field missing or empty: 'testResult'

Heads up — this is a new requirement. The repo's validation pipeline was rewritten in April/early May 2026 and we're still in transition: the contribution guide mentions testResult but a lot of in-flight PRs predate the change and don't have it. Apologies for the friction. The flow is now:

  1. Deploy azuredeploy.json to Azure yourself (any sub you have access to, any region). Capture the correlationId and deploymentName:
    az deployment group create \
      -g <your-rg> -n <some-deployment-name> \
      -f azuredeploy.json -p @azuredeploy.parameters.json \
      --query '{name:name, correlationId:properties.correlationId, state:properties.provisioningState}'
  2. Wait ~10–15 minutes for ARM logs to propagate into ADX (the validator queries these).
  3. Add a testResult block to metadata.json and bump dateUpdated to today:
    "dateUpdated": "2026-05-18",
    "testResult": {
      "deployments": {
        "templateFileName": "azuredeploy.json",
        "correlationId": "<guid from step 1>",
        "deploymentName": "<name from step 1>"
      }
    }
  4. Push the update — validate-samples will rerun automatically. Once it's green, a maintainer will comment /validate to run the deeper ADX-based deployment validation.

Reference in the contribution guide: metadata.json → testResult

Let me know if you hit issues with the deployment itself or have questions on the format.

@alex-frankel alex-frankel merged commit 7722af5 into Azure:master May 18, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

best practices violations BPA manual validation required This PR requires manual validation readme violations README violations during PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants