Skip to content

Remove obsolete ports#14733

Closed
zoran-rilak-msft wants to merge 2 commits into
Azure:masterfrom
zoran-rilak-msft:sqlmi-staleports-1
Closed

Remove obsolete ports#14733
zoran-rilak-msft wants to merge 2 commits into
Azure:masterfrom
zoran-rilak-msft:sqlmi-staleports-1

Conversation

@zoran-rilak-msft
Copy link
Copy Markdown
Contributor

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@azure-quickstarts azure-quickstarts added the remove azuredeploy.json bicep sample, remove json from PR label May 7, 2026
@azure-quickstarts
Copy link
Copy Markdown
Collaborator

@stevestein - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

@alex-frankel
Copy link
Copy Markdown
Contributor

Thanks for the cleanup. A couple of things to look at:

1. AzQuickStarts-MAC failure (legacy pipeline). I haven't dug into the build log — could you take a look at the linked ADO build and share what you find? Likely worth resolving before merge.

2. New testResult metadata. The contribution guide was recently updated to ask contributors to deploy the template and capture the deployment results (correlationId, deploymentName) in metadata.json under testResult.deployments. It's not yet strictly required for existing-sample edits like these, but please add it if you can — it'll become the standard going forward and helps the new ADX-based validation flow. Details and format: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md#testresult

@azure-quickstarts
Copy link
Copy Markdown
Collaborator

@stevestein - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

@alex-frankel
Copy link
Copy Markdown
Contributor

Closing as stale — no updates in ~2 weeks and the PR is missing the required metadata.json testResult block (see CONTRIBUTION-GUIDE for the new validator contract). Please reopen with a fresh deployment stamped into metadata.json. Note also that this sample has a main.bicep — changes should be made there, not directly in azuredeploy.json (which is a generated artifact).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remove azuredeploy.json bicep sample, remove json from PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants