Add merge script to vegeta module#63
Merged
Merged
Conversation
OliverMKing
reviewed
Apr 1, 2026
| # Note: The first and last second-buckets may be partial (vegeta doesn't start/stop exactly | ||
| # on second boundaries). Consumers should account for this when validating RPS values. | ||
|
|
||
| set -e |
Contributor
There was a problem hiding this comment.
Consider adding set -o pipefail here (i.e. set -eo pipefail).
The merge pipeline is vegeta encode | sort | gawk. Without pipefail, if vegeta encode fails on a corrupted .bin file, sort and gawk will process empty/partial data and exit 0, producing incorrect (or empty) output silently. The subsequent empty-file check would only catch the fully-empty case, not partial/corrupt output.
Same applies to run.sh (pre-existing).
Contributor
Author
There was a problem hiding this comment.
This is a really good catch, I'll update for this
OliverMKing
approved these changes
Apr 1, 2026
OliverMKing
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality of merging results following a distributed load test setup.
- New script that takes one or more raw vegeta .bin files and produces jaggr-format per-second JSON output
- Uses gawk with actual request timestamps for bucketing (not wall-clock time)
- Works correctly on saved/replayed data and correctly interleaves results from pods that started at slightly different times
- Added tests for .bin file production, per-second bucketing correctness, single-file merge, simultaneous multi-file merge, and synthetic latency percentile verification with exact expected
values
- New test-merge job that runs 4 simultaneous vegeta attacks at 50 RPS for 15s, merges the results, and validates line count, combined RPS, code histogram integrity, and JSON structure
- Added gawk to CI module-test dependencies
- Server readiness loop fails explicitly with container logs on timeout