fix: guard openInEditor when inspector is unavailable#1098
Open
Akur1a wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
Akur1a
force-pushed
the
fix/open-in-editor-options-api
branch
from
6af80b4 to
111f768
Compare
When the component inspector is not initialized, calling openInEditor through the Vite plugin path throws because __VUE_INSPECTOR__ is missing. Guard the call and log a clear warning instead, so DevTools does not crash in this state. Refs vuejs#824
Akur1a
force-pushed
the
fix/open-in-editor-options-api
branch
from
111f768 to
aac3432
Compare
Akur1a
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a small guard around the Vite plugin open-in-editor path so DevTools does not throw when the component inspector has not been initialized.
In that state
__VUE_INSPECTOR__is unavailable, so callingopenInEditordirectly raises a TypeError. With this change, DevTools skips the call and logs a clearer warning instead.Refs #824