Refactor error position parsing to support path with colons

Author: jim-liu

analyzer.go

@@ -29,6 +29,7 @@ import (
 	"path"
 	"path/filepath"
 	"reflect"
+	"regexp"
 	"runtime/debug"
 	"strconv"
 	"strings"
@@ -761,19 +762,24 @@ func ParseErrors(pkg *packages.Package) (map[string][]Error, error) {
 		return nil, nil
 	}
 	errs := make(map[string][]Error)
-	var posRegexp = regexp.MustCompile(`^(.*?)(?::(\d+))?(?::(\d+))?$`)
+	var posRegexp = regexp.MustCompile(`^(.*?)(?::(\w+))?(?::(\w+))?$`)
 	for _, pkgErr := range pkg.Errors {
 		matches := posRegexp.FindStringSubmatch(pkgErr.Pos)
 		file := pkgErr.Pos
+		var err error
 		var line, column int
 		if len(matches) > 0 {
 			file = matches[1]
 			file = strings.TrimSuffix(file, ":")
 			if matches[2] != "" {
-				line, _ = strconv.Atoi(matches[2])
+				if line, err = strconv.Atoi(matches[2]); err != nil {
+					return nil, fmt.Errorf("parsing line: %w", err)
+				}
 			}
 			if matches[3] != "" {
-				column, _ = strconv.Atoi(matches[3])
+				if column, err = strconv.Atoi(matches[3]); err != nil {
+					return nil, fmt.Errorf("parsing column: %w", err)
+				}
 			}
 		}
 		msg := strings.TrimSpace(pkgErr.Msg)

analyzer_test.go

@@ -1803,6 +1803,26 @@ func main() {
 			Expect(err).Should(HaveOccurred())
 		})
 
+		It("should properly parse the errors with colons in path", func() {
+			pkg := &packages.Package{
+				Errors: []packages.Error{
+					{
+						Pos: "C:\\file:1:2",
+						Msg: "build error",
+					},
+				},
+			}
+			errors, err := gosec.ParseErrors(pkg)
+			Expect(err).ShouldNot(HaveOccurred())
+			Expect(errors).To(HaveLen(1))
+			for _, ferr := range errors {
+				Expect(ferr).To(HaveLen(1))
+				Expect(ferr[0].Line).To(Equal(1))
+				Expect(ferr[0].Column).To(Equal(2))
+				Expect(ferr[0].Err).Should(MatchRegexp(`build error`))
+			}
+		})
+
 		It("should append  error to the same file", func() {
 			pkg := &packages.Package{
 				Errors: []packages.Error{