sippy/.golangci.yml at main · openshift/sippy · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
---
version: "2"

run:
  concurrency: 6
  timeout: 10m

linters:
  default: none
  enable:
    - copyloopvar
    - errcheck
    # - goconst  # [lmeyer] I cannot see a way to configure this sanely
    - gocritic
    - gocyclo
    - gosec
    - govet
    - ineffassign
    - misspell
    - revive
    - staticcheck
    - unconvert
    - unparam
  settings:
    gocritic:
      disable-all: true # let's only enable ones we opt in to, not random new ones
      enabled-checks:
        # Diagnostic
        - argOrder
        - badCond
        - caseOrder
        - codegenComment
        - commentedOutCode
        - deprecatedComment
        - dupArg
        - dupBranchBody
        - dupCase
        - dupSubExpr
        - exitAfterDefer
        - flagDeref
        - flagName
        - nilValReturn
        - octalLiteral
        - offBy1
        - sloppyReassign
        - weakCond

        # Performance
        - equalFold
        - indexAlloc
        - rangeExprCopy

        # Style
        - assignOp
        - boolExprSimplify
        - captLocal
        - commentFormatting
        - commentedOutImport
        - defaultCaseOrder
        - docStub
        - elseif
        - emptyFallthrough
        - hexLiteral
        - methodExprCall
        - regexpMust
        - singleCaseSwitch
        - sloppyLen
        - switchTrue
        - typeAssertChain
        - typeSwitchVar
        - underef
        - unlabelStmt
        - unlambda
        - unslice
        - valSwap
        - wrapperFunc
        - yodaStyleExpr

        # Opinionated
        - initClause
        - nestingReduce
        - paramTypeCombine
        - ptrToRefParam
        - typeUnparen
        - unnecessaryBlock
    revive:
      rules:
        - name: atomic
        - name: blank-imports
        - name: bool-literal-in-expr
        - name: call-to-gc
        - name: confusing-naming
        - name: constant-logical-expr
        - name: context-as-argument
        - name: context-keys-type
        - name: deep-exit
        - name: defer
        - name: dot-imports
        - name: duplicated-imports
        - name: early-return
        - name: empty-block
        - name: error-naming
        - name: error-return
        - name: error-strings
        - name: errorf
        - name: get-return
        - name: identical-branches
        - name: if-return
        - name: import-shadowing
        - name: imports-blacklist
        - name: increment-decrement
        - name: indent-error-flow
        - name: modifies-parameter
        - name: modifies-value-receiver
        - name: package-comments
        - name: range
        - name: range-val-address
        - name: range-val-in-closure
        - name: receiver-naming
        - name: redefines-builtin-id
        - name: string-of-int
        - name: struct-tag
        - name: superfluous-else
        - name: time-naming
        - name: unconditional-recursion
        - name: unexported-naming
        - name: unnecessary-stmt
        - name: unreachable-code
        # TODO: Enable these in the future
        # - name: unused-parameter
        # - name: unused-receiver
        - name: var-declaration
        - name: var-naming
        - name: waitgroup-by-value
  exclusions:
    generated: lax
    presets:
      - comments
      - common-false-positives
      - legacy
      - std-error-handling
    rules:
      - linters: [revive]
        text: "var-naming: avoid meaningless package names" # pkg/api, pkg/util, pkg/api/componentreadiness/utils
      - linters: [revive]
        text: "var-naming: avoid package names that conflict" # pkg/sippyserver/metrics, pkg/version
    paths:
      - sippy-ng/node_modules

formatters:
  enable:
    - gofmt
    - goimports
  settings:
    gofmt:
      simplify: false # do not require the -s flag
  exclusions:
    generated: lax
    paths:
      - sippy-ng/node_modules