OCPBUGS-85628: Fix OCP e2e flakiness for oc image info#31176
OCPBUGS-85628: Fix OCP e2e flakiness for oc image info#31176YamunadeviShanmugam wants to merge 5 commits into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
jira/valid-reference
|
@YamunadeviShanmugam: This pull request references Jira Issue OCPBUGS-85628, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe test now reads the cluster payload image from clusterversion (.status.desired.image), trims and validates it, prepares registry auth/CA material, runs ChangesDynamic Payload Image Test Refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 9 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@YamunadeviShanmugam: This pull request references Jira Issue OCPBUGS-85628, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/extended/images/info.go`:
- Around line 42-56: The current logic assigns prepErr to err and then runs the
HyperShift check, causing "oc image info failed..." to be reported even when
PrepareImagePullSecretAndCABundle failed; update the flow in
test/extended/images/info.go so that PrepareImagePullSecretAndCABundle errors
are handled separately: if prepErr != nil then assert/report prepErr directly
(e.g., o.Expect(prepErr).NotTo(o.HaveOccurred()) or fail with the prepErr
message) or, if you intend to allow prep failures only on HyperShift, perform
exutil.IsHypershift(ctx, oc.AdminConfigClient()) and call g.Skip() on HyperShift
before asserting prepErr; only perform the
oc.AsAdmin().Run("image").Args(...).Output() call and the subsequent HyperShift
check when PrepareImagePullSecretAndCABundle succeeded (prepErr == nil), and use
the existing isHyperShift logic to skip or assert the actual oc image info
error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: dd06303b-b7d4-4120-91ae-e0ceefeaa428
📒 Files selected for processing (1)
test/extended/images/info.go
openshift-merge-bot
Bot
added
the
ready-for-human-review
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangwgr, YamunadeviShanmugam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
Scheduling required tests: Scheduling tests matching the |
|
New changes are detected. LGTM label has been removed. |
|
Scheduling required tests: Scheduling tests matching the |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest-required |
|
Job Failure Risk Analysis for sha: 1591e24
|
|
/retest |
|
@YamunadeviShanmugam: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
5 participants
The original test was failing because it relied on a hardcoded OpenShift image from an external registry which in turn caused failures. To fix this, the test is made dynamic by having it pull the actual payload image used by the cluster instead of a static string.
Summary by CodeRabbit
Note: Internal testing improvements only; no user-facing changes.