Clarify View name is not subject to instrument name syntax validation#5094
Merged
lmolkova merged 6 commits intoMay 19, 2026
Merged
Conversation
Contributor
|
I also checked (using AI, with references):
|
dashpole
approved these changes
May 15, 2026
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
I think it is fine to use MUST NOT as long as the maintainers for .NET and Rust are on-board to change after this merges.
Member
Author
@martincostello Could you check if .NET is okay? (I am okay, and can send the PR with the fix to adjust to this, if this is merged) |
reyang
approved these changes
May 15, 2026
Member
|
@cijothomas Sounds ok to me. |
lalitb
approved these changes
May 15, 2026
Member
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. This matches current C++ SDK behavior: View-provided stream names are passed through without instrument-name syntax validation.
Member
Author
|
@jack-berg could you review? |
jack-berg
approved these changes
May 15, 2026
This was referenced May 15, 2026
Member
|
PR to add a test to codify the opentelemetry-java behavior: open-telemetry/opentelemetry-java#8412 |
lzchen
approved these changes
May 18, 2026
Member
Author
|
@carlosalberto Could you merge this in and include it part of release #5096 ? |
Merged
pull Bot
pushed a commit
to CodeWeaver13/opentelemetry-specification
that referenced
this pull request
May 20, 2026
### Metrics - Add in-development `Bind` API to synchronous instruments. ([open-telemetry#5050](open-telemetry#5050)) - Clarify that View-provided metric stream `name` is not subject to instrument name syntax validation. ([open-telemetry#5094](open-telemetry#5094)) ### Common - Define the Core packages term. ([open-telemetry#5046](open-telemetry#5046)) - Rework contributing guide to reflect current process. ([open-telemetry#5072](open-telemetry#5072)) ### Compatibility - Stabilize sections of Prometheus and OpenMetrics Compatibility. - Stabilize translation of labels prefixed with `otel_scope_` to OTLP Instrumentation Scope. ([open-telemetry#5004](open-telemetry#5004)) - Stabilize OpenTelemetry Gauge and Sum to Prometheus transformations. ([open-telemetry#5034](open-telemetry#5034)) - Stabilize OpenTelemetry Instrumentation Scope to Prometheus labels transformation. ([open-telemetry#5052](open-telemetry#5052)) - Stabilize sections of Prometheus Metrics Exporter. - Stabilize temporality. ([open-telemetry#5024](open-telemetry#5024)) - Stabilize version and format. ([open-telemetry#5083](open-telemetry#5083)) - Stabilize port configuration. ([open-telemetry#5026](open-telemetry#5026)) - Stabilize `scope_info_enabled` configuration. ([open-telemetry#5056](open-telemetry#5056)) - Change Prometheus Metric Exporter config property recommended names (`without_scope_info` -> `scope_info_enabled`, `without_target_info` -> `target_info_enabled`, `with_resource_constant_labels` -> `resource_constant_labels`) ([open-telemetry#5071](open-telemetry#5071)) - Clarify that OTel SDKs should not use unofficial Prometheus clients. ([open-telemetry#5082](open-telemetry#5082)) ### OTEPs - Add OTEP for Semantic Convention Schema v2 with support for multiple convention registries and resolved schema format ([open-telemetry#4815](open-telemetry#4815)) --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK spec is currently silent on whether the metric stream
nameprovided via View stream configuration must conform to the instrument name syntax. Implementations have diverged on this: .NET and Rust validate the View-provided name against the instrument name syntax (and reject/drop the stream on mismatch), while Go, Java, Python, and C++ pass it through without validation.This PR makes the spec explicit that View-provided names are not subject to instrument name syntax validation.
Discussion context: #5092 (comment) and follow-ups.