Stop validating View-provided stream Name against instrument name syntax#7300
Merged
martincostello merged 4 commits intoMay 20, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7300 +/- ##
==========================================
+ Coverage 89.87% 89.92% +0.05%
==========================================
Files 276 276
Lines 14007 14001 -6
==========================================
+ Hits 12589 12591 +2
+ Misses 1418 1410 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
May 19, 2026
Member
Author
|
@martincostello could you re-review and merge if all okay? |
martincostello
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the OpenTelemetry specification clarification in open-telemetry/opentelemetry-specification#5094, the View-provided metric stream
Nameis NOT subject to the instrument name syntax and the SDK MUST NOT validate it against that syntax.Removes name-syntax validation from
MetricStreamConfiguration.Namesetter, theAddView(instrumentName, name)overload, and the runtime check inMetricReaderExt(which now only validates names that originate from the instrument itself, not View-renamed names). Also removes the now-unused internalMeterProviderBuilderSdk.IsValidViewName. Direct instrument creation viaMetercontinues to enforce the syntax.Spec PR: open-telemetry/opentelemetry-specification#5094
Update (2026-05-19): Spec PR open-telemetry/opentelemetry-specification#5094 has been merged.