Relax instrument name validation per opentelemetry-specification#5092#7297
Closed
cijothomas wants to merge 1 commit into
Closed
Relax instrument name validation per opentelemetry-specification#5092#7297cijothomas wants to merge 1 commit into
cijothomas wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7297 +/- ##
==========================================
+ Coverage 89.85% 89.93% +0.07%
==========================================
Files 273 273
Lines 13773 13773
==========================================
+ Hits 12376 12387 +11
+ Misses 1397 1386 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Closing — open-telemetry/opentelemetry-specification#5092 was closed in favor of using Views for these cases (per spec clarification open-telemetry/opentelemetry-specification#5094). The Meter-level instrument name relaxation is no longer needed. The View-level fix is tracked in #7300. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — depends on opentelemetry-specification#5092. Will be ready for review once the spec PR is merged.
Description
Relaxes the SDK instrument-name validation to match the proposed expanded character set in opentelemetry-specification#5092:
:,\,(,),%,*,#, and space to the allowed character set.This enables Windows performance counter style names to be used directly as instrument names without workarounds — e.g.
\Processor(_Total)\% Processor Time,\.NET CLR Memory(*)\# Bytes in all Heaps.Backwards compatibility
Strict superset of the existing rule. Every name valid under the old regex remains valid; some previously-rejected names are now accepted.