NIT Changes

Author: avishmsft

src/Agent.Worker/TestResults/ResultsCommandExtension.cs

@@ -80,11 +80,6 @@ public void Execute(IExecutionContext context, Command command)
 
             TestRunContext runContext = CreateTestRunContext();
 
-            // Capture all mutable instance state as locals before the async continuation.
-            // The command lock (_commandSerializeLock in WorkerCommandManager) releases when
-            // Execute() returns, but the async task continues running. A subsequent Execute()
-            // call would overwrite these instance fields, causing the in-flight async task to
-            // read corrupted state. Capturing as locals makes the async task self-contained.
             var executionContext = _executionContext;
             var testResultFiles = _testResultFiles;
             var testRunner = _testRunner;
@@ -386,12 +381,12 @@ private async Task PublishTestRunDataAsync(
         }
 
         // Queue code coverage merge job if code coverage attachments are published to avoid BQC timeout.
-        private void TriggerCoverageMergeJob(List<string> resultFilesInput, IExecutionContext executionContext)
+        private void TriggerCoverageMergeJob(List<string> resultFilesInput, IExecutionContext context)
         {
             try
             {
-                ITestResultsServer _testResultsServer = executionContext.GetHostContext().GetService<ITestResultsServer>();
-                using (var connection = WorkerUtilities.GetVssConnection(executionContext))
+                ITestResultsServer _testResultsServer = context.GetHostContext().GetService<ITestResultsServer>();
+                using (var connection = WorkerUtilities.GetVssConnection(context))
                 {
                     foreach (var resultFile in resultFilesInput)
                     {
@@ -411,14 +406,14 @@ private void TriggerCoverageMergeJob(List<string> resultFilesInput, IExecutionCo
                                     Path.GetExtension(file).Equals(".coverage", StringComparison.OrdinalIgnoreCase)
                                     )
                                 {
-                                    _testResultsServer.InitializeServer(connection, executionContext);
+                                    _testResultsServer.InitializeServer(connection, context);
                                     try
                                     {
-                                        var codeCoverageResults = _testResultsServer.UpdateCodeCoverageSummaryAsync(connection, executionContext.Variables.System_TeamProjectId.ToString(), executionContext.Variables.Build_BuildId.GetValueOrDefault());
+                                        var codeCoverageResults = _testResultsServer.UpdateCodeCoverageSummaryAsync(connection, context.Variables.System_TeamProjectId.ToString(), context.Variables.Build_BuildId.GetValueOrDefault());
                                     }
                                     catch (Exception e)
                                     {
-                                        executionContext.Section($"Could not queue code coverage merge:{e}");
+                                        context.Section($"Could not queue code coverage merge:{e}");
                                     }
                                 }
                             }
@@ -428,7 +423,7 @@ private void TriggerCoverageMergeJob(List<string> resultFilesInput, IExecutionCo
             }
             catch (Exception e)
             {
-                executionContext.Debug($"Exception in Method:{e.Message}");
+                context.Debug($"Exception in Method:{e.Message}");
             }
         }