channels: stop distributing the standalone binary#18374
Conversation
The kops-channels static pod (added in kubernetes#18328) replaces the standalone channels binary that protokube used to invoke. This drops the binary from asset distribution, GitHub release uploads, and the per-node asset download list. `make channels` is kept as a local build target for debugging.
k8s-ci-robot
added
size/L
|
This is ready for review. |
| CHANNELS=$(kops-channels-download-from-base) | ||
| export CHANNELS |
There was a problem hiding this comment.
Do we need to keep this around for testing older kops versions? Its not clear to me how CHANNELS is even used
There was a problem hiding this comment.
it can still be built, but not distributed
There was a problem hiding this comment.
I am also not sure if anyone uses it
There was a problem hiding this comment.
It needed to be distributed in order for kops to have download location
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
The kops-channels static pod (added in #18328) replaces the standalone channels binary that protokube used to invoke. This drops the binary from asset distribution, GitHub release uploads, and the per-node asset download list.
make channelsis kept as a local build target for debugging./cc @rifelpet