Skip to content

Cleanup prereqs and add links to install.md page#1146

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
a-mccarthy:cleanup-links
May 22, 2026
Merged

Cleanup prereqs and add links to install.md page#1146
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
a-mccarthy:cleanup-links

Conversation

@a-mccarthy
Copy link
Copy Markdown
Contributor

@a-mccarthy a-mccarthy commented May 15, 2026

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR is related to:

  • Cleans up some links to the wiki install page to point to new install page, and docs folder
  • removed dra feature gate details from prereqs page, since the min k8s version is now 1.34+ and its enabled by default.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation (design docs, usage docs, etc.):

Checklist

  • make check test passes locally
  • make check-generate passes if api/ changed (CRDs, deepcopy, informers, listers, clientset)
  • make check-modules passes if go.mod / go.sum changed
  • Tests added or updated for the change
  • Helm chart (deployments/helm) updated if flags, RBAC, or defaults changed

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 15, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026 •
edited
Loading

✅ Deploy Preview for dra-driver-nvidia-gpu ready!

Name Link
🔨 Latest commit 2e3e171
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a0c702a77fd2f00089f6054
😎 Deploy Preview https://deploy-preview-1146--dra-driver-nvidia-gpu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2026

Hi @a-mccarthy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2026
@a-mccarthy
Copy link
Copy Markdown
Contributor Author

a-mccarthy commented May 15, 2026

I was thinking in the short term i was thinking we can point to the /docs folder instead of the docs folder. and then update the links when we have the website ready. Does this work?

I dont have access to the Wiki pages itself, but we should update the install and upgrade sections to point folks to the new /docs folder.

bmozaffa
bmozaffa suggested changes May 18, 2026
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/question.yml Outdated
Comment thread docs/prerequisites.md Outdated
@a-mccarthy
Cleanup prereqs and add links to install.md page
2e3e171 
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
@a-mccarthy a-mccarthy requested a review from bmozaffa May 19, 2026 14:14
bmozaffa
bmozaffa approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown

@bmozaffa bmozaffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamerla
Copy link
Copy Markdown
Contributor

shivamerla commented May 22, 2026

I was thinking in the short term i was thinking we can point to the /docs folder instead of the docs folder. and then update the links when we have the website ready. Does this work?

I dont have access to the Wiki pages itself, but we should update the install and upgrade sections to point folks to the new /docs folder.

Yes, that sounds good, once we have the website ready we can update all links at once.

@shivamerla
Copy link
Copy Markdown
Contributor

shivamerla commented May 22, 2026

/lgtm
/approve
/release-note-none
/hold cancel once ready

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 22, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 22, 2026

LGTM label has been added.

DetailsGit tree hash: 67bd5f3bac02b7a16d4930cd88f53957c4119803

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-mccarthy, bmozaffa, shivamerla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2026
@k8s-ci-robot k8s-ci-robot merged commit d795d6f into kubernetes-sigs:main May 22, 2026
13 of 16 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in DRA Driver for NVIDIA GPUs May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shengnuo shengnuo Awaiting requested review from shengnuo

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale

1 more reviewer

@bmozaffa bmozaffa bmozaffa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shivamerla shivamerla

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

DRA Driver for NVIDIA GPUs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-mccarthy @k8s-ci-robot @shivamerla @bmozaffa